After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594471 - Shouldn't call e_error_new/run with NULL 'parent'
Shouldn't call e_error_new/run with NULL 'parent'
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-09-08 10:01 UTC by Akhil Laddha
Modified: 2014-02-23 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Akhil Laddha 2009-09-08 10:01:41 UTC 
Evolution 2.29.1 

When i start evolution, it pops up a dialog which says 'Do you want to make evolution default mail client', i see warning on evolution terminal.

(evolution:23266): e-utils-WARNING **: Something called e_error_newv() with a NULL parent window.  This is no longer legal, please fix it.

gdb traces

+ Trace 217404







Comment 1


Matthew Barnes





          2009-09-08 12:08:08 UTC
        



I added that warning to help track down anything that still relies on the Bonobo-necessitated default parent window hack in e-error.c.

I don't suppose the main window is up yet when this dialog appears?

If there's legitimate cases for passing a NULL parent window to e_error_new(), then we should make it greppable:

    e_error_new()            <- warns as above
    e_error_new_no_parent()  <- does not warn






Comment 2


Akhil Laddha





          2009-09-09 04:47:17 UTC
        



(In reply to comment #1)

> I don't suppose the main window is up yet when this dialog appears?
> 

Yeah, first this dialog appears and later evolution mail windows shows up. I didn't cancel dialog till main window shows up.






Comment 3


Akhil Laddha





          2009-10-06 05:32:22 UTC
        



I get same warning when i try to subscribe to other user's folder in exchange 2003 provider.






Comment 4


Milan Crha





          2009-10-13 14:32:46 UTC
        



I walked through evo and eex sources and checked all the direct calls to e_error_new/e_error_run and replaced all those with NULL used there. I believe I didn't overlooked any. Thus the warning can be safely removed, because:

Created commit e06b88c in evo master (2.29.1+)
Created commit f333e0a in eex master (2.29.1+)

Note I also added e_shell_get_active_window function, which kicked off quite few duplicate code around the sources.






Comment 5


André Klapper





          2014-02-23 15:45:37 UTC
        



Closing as per Milan's comment 4 - this is likely fixed since 2009.