After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594438 - [PATCH] Use pkg-config to determine path to X server
[PATCH] Use pkg-config to determine path to X server
Status: RESOLVED DUPLICATE of bug 588848
Product: gdm
Classification: Core
Component: general
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-07 22:46 UTC by DJ Lucas
Modified: 2010-06-21 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description DJ Lucas 2009-09-07 22:46:20 UTC 
I install to alternate path (/opt/X11), please try a last ditch attempt prior to defaulting...

Something simple like this should be sufficient:

--- configure.ac	2009-03-16 14:50:10.000000000 -0500
+++ configure.ac.new	2009-09-07 17:38:47.000000000 -0500
@@ -1133,6 +1133,13 @@
    X_SERVER_PATH="/usr/bin"
    X_SERVER="/usr/bin/X"
    X_CONFIG_OPTIONS="-audit 0"
+elif test -x "`$PKG_CONFIG --variable=prefix xorg-server`/bin/X"; then
+   # last chance attempt to locate it via pkg-config before doing
+   # the wrong thing below
+   X_PATH="`$PKG_CONFIG --variable=prefix xorg-server`/bin"
+   X_SERVER_PATH="$X_PATH/bin"
+   X_SERVER="$X_PATH/bin/X"
+   X_CONFIG_OPTIONS="-audit 0"
 else
    # what to do, what to do, this is wrong, but this just sets the
    # defaults, perhaps this user is cross compiling or some such
Comment 1 DJ Lucas 2009-09-07 23:19:36 UTC 
Oops...wrong patch...the determined paths are bad in that one...had a thinko.  Correct patch below:

--- gdm-2.26.1-orig/configure.ac	2009-03-16 14:50:10.000000000 -0500
+++ gdm-2.26.1/configure.ac	2009-09-07 18:16:04.000000000 -0500
@@ -1133,6 +1133,13 @@
    X_SERVER_PATH="/usr/bin"
    X_SERVER="/usr/bin/X"
    X_CONFIG_OPTIONS="-audit 0"
+elif test -x "`$PKG_CONFIG --variable=prefix xorg-server`/bin/X"; then
+   # last chance attempt to locate it via pkg-config before doing
+   # the wrong thing below
+   X_PATH="`$PKG_CONFIG --variable=prefix xorg-server`/bin"
+   X_SERVER_PATH="$X_PATH"
+   X_SERVER="$X_PATH/X"
+   X_CONFIG_OPTIONS="-audit 0"
 else
    # what to do, what to do, this is wrong, but this just sets the
    # defaults, perhaps this user is cross compiling or some such
Comment 2 William Jon McCann 2010-06-19 14:05:45 UTC 
I don't have a xorg-server .pc file here.  Is that from upstream xorg?
Comment 3 DJ Lucas 2010-06-20 03:33:38 UTC 
Yes, I can only _confirm_ to 1.7.4 ATM (oldest I have laying around), but I'm pretty sure that it has been there since the very beginning of the Xorg individual packages. I would have assumed that it would be a part of the xorg-server-devel package (or similar), but I might be assuming too much as I don't split upstream packages into smaller parts (development packages are absolutely required for my readers/users).
Comment 4 William Jon McCann 2010-06-21 17:36:42 UTC 

*** This bug has been marked as a duplicate of bug 588848 ***