After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594234 - Gio port
Gio port
Status: RESOLVED FIXED
Product: tinymail
Classification: Deprecated
Component: libtinymail
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jose Dapena Paz
Maintainers of tinymail
Depends on:
Blocks: 588322
 
 
Reported: 2009-09-05 14:31 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-10-15 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Gio port (27.84 KB, patch)
2009-09-05 14:31 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review
Gio port.v2 (2.06 KB, patch)
2009-09-28 16:30 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Gio port.v3 (1.54 KB, patch)
2009-10-15 09:04 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Gio port.v3 (33.27 KB, patch)
2009-10-15 09:06 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Patch: add GIO support (v4) (40.00 KB, patch)
2009-10-15 15:52 UTC, Jose Dapena Paz 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-09-05 14:31:57 UTC 
Created attachment 142540 [details] [review]
Gio port

Here a Gio port for tinymail.

This is my first patch about GIO stuff, so any comment will be very welcome

Regards
Comment 1 Philip Van Hoof 2009-09-27 13:32:34 UTC 
Same comments as on the mailing list:

This patch is missing the Makefile.am in libtinymail-gio

Please also check the stuff in configure.ac because it apparently didn't
work for me (it didn't select to compile libtinymail-gio, although I
have all of GIO installed properly).

Can you also make it detect availability of GIO instead of assuming that
the developer needs libtinymail-gio? In case GIO is found, the default
should be to build libtinymail-gio, and it should be possible to
optionally disable the build of it.

The platform selection is irrelevant for this (so test on availability
of GIO instead of GNOME being selected as target platform).

Discussion in ML:

http://mail.gnome.org/archives/tinymail-devel-list/2009-September/msg00006.html
Comment 2 Philip Van Hoof 2009-09-27 13:33:22 UTC 
Comment on attachment 142540 [details] [review]
Gio port

- Makefile.am missing
- Use availability of GIO instead of platform selection to enable/disable the library's compilation
Comment 3 Javier Jardón (IRC: jjardon) 2009-09-28 16:30:46 UTC 
Created attachment 144186 [details] [review]
Gio port.v2

Here a new version of the patch with the comments of Philip

After apply the patch, you should compile with:

./autogen.sh --enable-gnome=no

because libtinymailui-gtk (needed for gnome support) should be ported to libtynimail-gio first.
Comment 4 Philip Van Hoof 2009-10-15 08:47:37 UTC 
Looks like that was the wrong patch, Javier.
Comment 5 Javier Jardón (IRC: jjardon) 2009-10-15 09:04:14 UTC 
Created attachment 145492 [details] [review]
Gio port.v3

Oops, sorry. Seems that I'm too used to git ;)
Comment 6 Javier Jardón (IRC: jjardon) 2009-10-15 09:06:48 UTC 
Created attachment 145493 [details] [review]
Gio port.v3
Comment 7 Jose Dapena Paz 2009-10-15 15:52:33 UTC 
Created attachment 145533 [details] [review]
Patch: add GIO support (v4)

Another iteration of the patch:
* Removed usage of gnomevfs based streams in all tinymail
* Build both GIO and GNOMEVFS streams if possible (just for compatibility).
* Some fixes in GIO implementation.
Comment 8 Sergio Villar 2009-10-15 16:04:18 UTC 
Review of attachment 145533 [details] [review]:

Don't forget to remove the generated files from the patch. The rest of the implementation looks good
Comment 9 Jose Dapena Paz 2009-10-15 17:04:35 UTC 
Committed the GIO support patch, to tinymail trunk r4030. Then fixed.