GNOME Bugzilla – Bug 594234
Last modified: 2009-10-15 17:05:17 UTC
Created attachment 142540 [details] [review]
Here a Gio port for tinymail.
This is my first patch about GIO stuff, so any comment will be very welcome
Same comments as on the mailing list:
This patch is missing the Makefile.am in libtinymail-gio
Please also check the stuff in configure.ac because it apparently didn't
work for me (it didn't select to compile libtinymail-gio, although I
have all of GIO installed properly).
Can you also make it detect availability of GIO instead of assuming that
the developer needs libtinymail-gio? In case GIO is found, the default
should be to build libtinymail-gio, and it should be possible to
optionally disable the build of it.
The platform selection is irrelevant for this (so test on availability
of GIO instead of GNOME being selected as target platform).
Discussion in ML:
Comment on attachment 142540 [details] [review]
- Makefile.am missing
- Use availability of GIO instead of platform selection to enable/disable the library's compilation
Created attachment 144186 [details] [review]
Here a new version of the patch with the comments of Philip
After apply the patch, you should compile with:
because libtinymailui-gtk (needed for gnome support) should be ported to libtynimail-gio first.
Looks like that was the wrong patch, Javier.
Created attachment 145492 [details] [review]
Oops, sorry. Seems that I'm too used to git ;)
Created attachment 145493 [details] [review]
Created attachment 145533 [details] [review]
Patch: add GIO support (v4)
Another iteration of the patch:
* Removed usage of gnomevfs based streams in all tinymail
* Build both GIO and GNOMEVFS streams if possible (just for compatibility).
* Some fixes in GIO implementation.
Review of attachment 145533 [details] [review]:
Don't forget to remove the generated files from the patch. The rest of the implementation looks good
Committed the GIO support patch, to tinymail trunk r4030. Then fixed.