After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594214 - Remove deprecated Glib and GTK+ symbols
Remove deprecated Glib and GTK+ symbols
Status: RESOLVED FIXED
Product: gnome-pilot
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-pilot Maintainers
gnome-pilot Maintainers
Depends on:
Blocks: 560423 585692
 
 
Reported: 2009-09-05 10:44 UTC by André Klapper
Modified: 2010-08-09 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove deprecated Glib symbols (12.32 KB, patch)
2009-12-21 02:13 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description André Klapper 2009-09-05 10:44:24 UTC
Gnome-pilot depends on deprecated Glib and Gtk+ symbols.
These symbols will be removed for Gtk+ 3.0.

http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B
http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib

Patch contributors can found API references at http://library.gnome.org/devel/references and general Git information at http://live.gnome.org/Git/Developers .


According to http://www.gnome.org/~fpeters/299.html the following deprecated symbols are used:

=====Glib=====
g_basename, g_dirname, g_main_iteration, g_strcasecmp

=====Gtk+=====
GTK_CHECK_CAST, GTK_CHECK_CLASS_CAST, GTK_CHECK_CLASS_TYPE, GTK_CHECK_TYPE, GTK_CLASS_TYPE, GTK_SIGNAL_FUNC, GTK_SIGNAL_OFFSET, GtkClassInitFunc, GtkObjectInitFunc, GtkSignalFunc, GtkType, GtkTypeInfo, gdk_window_get_colormap, gtk_about_dialog_set_name, gtk_entry_new_with_max_length, gtk_list_insert_items, gtk_list_item_new_with_label, gtk_menu_append, gtk_object_get_data, gtk_object_new, gtk_object_ref, gtk_object_set, gtk_object_set_data, gtk_object_sink, gtk_object_unref, gtk_option_menu_get_menu, gtk_option_menu_set_history, gtk_option_menu_set_menu, gtk_progress_configure, gtk_progress_set_format_string, gtk_rc_style_unref, gtk_signal_connect, gtk_signal_disconnect, gtk_signal_disconnect_by_data, gtk_signal_emit, gtk_signal_emit_stop_by_name, gtk_signal_new, gtk_timeout_add, gtk_toggle_button_set_state, gtk_tooltips_new, gtk_tooltips_set_tip, gtk_type_class, gtk_type_new, gtk_type_unique
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-21 02:13:31 UTC
Created attachment 150143 [details] [review]
Remove deprecated Glib symbols
Comment 2 André Klapper 2010-01-27 18:33:01 UTC
ping - can Javier's patch please get reviewed/committed, as a first step here?
Comment 3 Matt Davey 2010-01-27 19:13:44 UTC
Hi Javier, André,

Thanks for the patch, and apologies for the delay in reviewing / comitting.  I should be able to get to this over the weekend.

Note that several of the symbols above have already been fixed as part of #590215.  The tougher symbols remaining are the gtksignal/gtkobject, migration.
Comment 4 Matt Davey 2010-02-01 23:39:07 UTC
Review of attachment 150143 [details] [review]:

Thanks for the patch.  I started working on this stuff months ago, but got rather bogged down when attaching the gobject and signals stuff.  I should have committed some of these simpler things as I went along.  If you want to work more on this stuff (I'd be delighted) let me know and I can give you some pointers.
Comment 5 Matt Davey 2010-08-08 15:48:43 UTC
GtkType --> GType, and most other stuff done now (on dbus branch, which will soon become master).  Some GtkSignals still have to go.
Comment 6 Matt Davey 2010-08-09 08:07:20 UTC
All done.  gnome-pilot now compiles with G_DISABLE_DEPRECATED, GNOME_DISABLE_DEPRECATED, GTK_DISABLE_DEPRECATED, and -Werror.

dbus branch merged to head, so all is up to date now.