GNOME Bugzilla – Bug 594101
[Indic] needed character class data updates to support unicode 5.1
Last modified: 2010-03-18 17:36:13 UTC
Created attachment 142451 [details] [review] Support Indic 5.1 unicode data in pango 2 line request 1) I see few character class data is still missing to support pango upto unicode 5.1 version for Indic 2) Here is combined patch attached.
Just to Note here, I still see few more bugs are in need of fixing Indic module and few of them also need change in character class data. Behdad, Do you want single patch that includes other bug patches here?
Behdad, Ping for comment#1
Code freeze right now. Will commit for .1 release.
Parag, please attach one patch that only changes character class for new characters and I'll commit that and make a .1 release.
Created attachment 144485 [details] [review] Indic Unicode 5.1 compatiblity for character class data Here is single patch addressing issues for bugs listed in "Depends on" bugs. Also, thanks to Sandeep Shedmake for his help in traiging Indic pango bugs.
As till date no review of the above patch happened and I am on vacation now, if you found any problem in above patch then we can fix and consider it for "Dec 16" .2 stable release. Thanks.
Parag, I'm fine with the changes for characters that were previously marked as xx, but for others, I'm hesitant to make any change without a test suite first. Or in depth analysis of why they changes are correct. Any help?
Ok, So we need some more steps to get Unicode 5.1 support. I will start now step by step discussion here and also in all other dependent bugs if needed. Step 1: I will attach patch where characters got new definition from xx. Please confirm this patch first.
Created attachment 146082 [details] [review] only new character class definitions included
I think its good if you commit above patch first otherwise it will create a lot of confusion for creating further patches (splitted patch from here and then Unicode 5.2 patch which may takes some time)
Committed.
(In reply to comment #11) > Committed. Wish you had included the long pending bugs for which enough explanation was provided like https://bugzilla.gnome.org/show_bug.cgi?id=565599
(In reply to comment #11) > Committed. Thanks. Lets discuss on other dependent bugs now. Once we come to some conclusions there, I will submit another patch here.
(In reply to comment #12) > (In reply to comment #11) > > Committed. > Wish you had included the long pending bugs for which enough explanation was > provided like > https://bugzilla.gnome.org/show_bug.cgi?id=565599 How was I supposed to do that? You submitted the patch and I applied it as is. Honestly you have overwhelmed me by opening so many inter-related bugs...
Behdad ping Can you please provide your feedback on dependent bugs? Or you want me to post remaining patch here? I guess Unicode 5.2 Indic work is small so we need to move Unicode 5.2 Indic support bug once this bug gets resolved.
We're getting to the point of the current Indic shaper being obsolete. HarfBuzz has a brand new written-from-scratch shaper.
Would now be a good time to start testing it? Is it possible to have a test snapshot or should we build a test package from git?
I see harfbuzz module is taking some time and there is no module yet for indic scripts. So I propose a new patch that will cover all remaining unicode characters till 5.1
Created attachment 150218 [details] [review] patch to fix exisiting class data definitions
No Indic changes will be committed until we have a test suite in place. I hope I have made it clear this time. Thanks.
Patch committed. Please TEST.
Created attachment 155194 [details] This image contains test rules for some unicode characters using incorrect rendering.
Created attachment 155195 [details] This image contains test rules for some unicode characters using corrected rendering.
Can we have some upstream tarball release to include this in Fedora rpm?
It will be soon. Pango is not ready yet.