After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594014 - gtk-engines: system-lua check is buggy
gtk-engines: system-lua check is buggy
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: general
2.18.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-03 10:54 UTC by Romain Perier
Modified: 2010-03-18 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
system_lua patch 2 (616 bytes, patch)
2009-09-22 07:01 UTC, Yaakov Selkowitz 		none Details | Review

Description Romain Perier 2009-09-03 10:54:16 UTC 
Hey,

Refering to upstream bug #593674, a buggy patch for system-lua was pushed.
It's just a minor bug :

-AC_ARG_WITH(system-lua,	[  --with-system-lua        link with system Lua library], [system_lua=$enableval], [system_lua="no"])
+AC_ARG_WITH(system-lua,	[  --with-system-lua        link with system Lua library], [system_lua=$withval], [system_lua="no"])

Otherwises it's impossible to exec the configure script correctly with the following options: --enable-animation --disable-lua --without-system-lua.

Regards,
Romain.
Comment 2 Yaakov Selkowitz 2009-09-22 07:01:37 UTC 
Created attachment 143659 [details] [review]
system_lua patch 2

One more patch is necessary post 2.18.3, attached.
Comment 3 Benjamin Berg 2009-09-22 09:44:31 UTC 
Thanks a lot for those fixes! I'll probably do a new release later today.

commit 5a5eb6dd706179da9294e939ede807170b99c1a5
Author: Benjamin Berg <benjamin@sipsolutions.net>
Date:   Tue Sep 22 11:43:28 2009 +0200

    Correct the SYSTEM_LUA conditional check. (patch from bug #594014)
Comment 4 Romain Perier 2009-09-23 10:37:16 UTC 
Bumped into the main tree (gentoo) and patch imported , thanks :)
Comment 5 Emilio Pozuelo Monfort 2010-03-16 20:41:35 UTC 
(In reply to comment #2)
> Created an attachment (id=143659) [details] [review]
> system_lua patch 2 [details]
> 
> One more patch is necessary post 2.18.3, attached.

This one hasn't been committed and is correct. Benjamin, can we get it in for 2.30?

Also the 2.19 tarball doesn't contain the liblua dir.
Comment 6 Benjamin Berg 2010-03-18 20:46:35 UTC 
OK, I forgot to cherry-pick the patch into the master branch. That is done.

And you are right that the liblua dir is missing, I have fixed this now.

(Seriously, I don't think that the lua engine is any useful. I am considering to remove it in the next release cycle. I have never seen a theme that uses it, or even an attempt of one yet.)