GNOME Bugzilla – Bug 593787
drop HAL code from gdm
Last modified: 2010-01-26 19:13:57 UTC
This bug was reported here: https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/418981 Hal is deprecated, see http://www.freedesktop.org/wiki/Software/hal ~/git/gdm(master)$ git grep HAL | grep -v marshal | grep -v po daemon/gdm-local-display-factory.c:#define HAL_DBUS_NAME "org.freedesktop.Hal" daemon/gdm-local-display-factory.c:#define HAL_DBUS_MANAGER_PATH "/org/freedesktop/Hal/Manager" daemon/gdm-local-display-factory.c:#define HAL_DBUS_MANAGER_INTERFACE "org.freedesktop.Hal.Manager" daemon/gdm-local-display-factory.c:#define HAL_DBUS_DEVICE_INTERFACE "org.freedesktop.Hal.Device" daemon/gdm-local-display-factory.c: g_warning ("Unable to query HAL: %s", error->message); daemon/gdm-local-display-factory.c: HAL_DBUS_NAME, daemon/gdm-local-display-factory.c: HAL_DBUS_DEVICE_INTERFACE); daemon/gdm-local-display-factory.c: g_warning ("Unable to query HAL: %s", error->message); daemon/gdm-local-display-factory.c: HAL_DBUS_NAME, daemon/gdm-local-display-factory.c: HAL_DBUS_MANAGER_PATH, daemon/gdm-local-display-factory.c: HAL_DBUS_MANAGER_INTERFACE); daemon/gdm-local-display-factory.c: g_warning ("Couldn't create proxy for HAL Manager"); daemon/test-hal-seats.c:#define HAL_DBUS_NAME "org.freedesktop.Hal" daemon/test-hal-seats.c:#define HAL_DBUS_MANAGER_PATH "/org/freedesktop/Hal/Manager" daemon/test-hal-seats.c:#define HAL_DBUS_MANAGER_INTERFACE "org.freedesktop.Hal.Manager" daemon/test-hal-seats.c:#define HAL_DBUS_DEVICE_INTERFACE "org.freedesktop.Hal.Device" daemon/test-hal-seats.c: g_warning ("Unable to query HAL: %s", error->message); daemon/test-hal-seats.c: HAL_DBUS_NAME, daemon/test-hal-seats.c: HAL_DBUS_DEVICE_INTERFACE); daemon/test-hal-seats.c: g_warning ("Unable to query HAL: %s", error->message); daemon/test-hal-seats.c: HAL_DBUS_NAME, daemon/test-hal-seats.c: HAL_DBUS_MANAGER_PATH, daemon/test-hal-seats.c: HAL_DBUS_MANAGER_INTERFACE);
Upstream gdm does not depend on hal, that was a Fedora/Ubuntu patch which is not necessary any more. See bug 572765.
Hello Martin, the code of comment #0 is from upstream gdm: http://git.gnome.org/cgit/gdm/ or the project change its location?
Ah, sorry, I missed that.
Created attachment 151407 [details] [review] disable connection to hal (PoC) We switched hal from an init script to dbus activation (since we usually don't need it any more), and indeed gdm currently unconditionally triggers startup. The code in daemon/gdm-local-display-factory.c that _uses_ the hal connection was commented out (upstream) ages ago, but that didn't include the connect_to_hal() stuff. So it just needlessly connects to hal now. Attached patch drops this, as a proof of concept that this works. If you want this upstream, I'm happy to provide a more extensive patch against git head which just removes all the hal bits.
Created attachment 151888 [details] [review] remove remaining traces of Hal This patch now cleans up properly, and is thus much more adequate for applying upstream. (Just harder to maintain in a distribution). Since it does not really imply functional changes except for not needlessly connecting to hal any more, this should be quite unanimous. However, I'd still like to get an ack from the maintainers that it's okay to commit upstream. Thanks for considering! Martin
Comment on attachment 151888 [details] [review] remove remaining traces of Hal thanks.
Thanks for review. Pushed.