After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593736 - play button is empty
play button is empty
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal blocker
: 0.13.3
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-01 00:13 UTC by Jean-François Fortin Tam
Modified: 2009-09-04 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of the problem (55.20 KB, image/png)
2009-09-01 00:13 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2009-09-01 00:13:18 UTC
Created attachment 142177 [details]
screenshot of the problem

Thanks, gtk devs (bug #583352).
Comment 1 Edward Hervey 2009-09-01 09:17:31 UTC
hmm.... so what shall we do for this ?
Comment 2 Andreas Nilsson 2009-09-01 12:38:02 UTC
This kind of play/pause combo seems to work well in Totem and Banshee, regardless of what the gconf-key is set to. How does that code differ?
Comment 3 Edward Hervey 2009-09-04 07:17:25 UTC
grrr... just installed latest gtk+ on my system... and there's indeed a lot of screwups.

This is our code for the play/pause button. Any idea on what we're doing wrong is more than welcome.

class PlayPauseButton(gtk.Button, Loggable):
    """ Double state gtk.Button which displays play/pause """

    __gsignals__ = {
        "play" : ( gobject.SIGNAL_RUN_LAST,
                   gobject.TYPE_NONE,
                   (gobject.TYPE_BOOLEAN, ))
        }

    def __init__(self):
        gtk.Button.__init__(self, label="")
        Loggable.__init__(self)
        self.playing = True
        self.setPlay()
        self.connect('clicked', self._clickedCb)

    def set_sensitive(self, value):
        gtk.Button.set_sensitive(self, value)

    def _clickedCb(self, unused):
        self.emit("play", self.playing)

    def setPlay(self):
        """ display the play image """
        self.log("setPlay")
        if self.playing:
            self.set_image(gtk.image_new_from_stock(gtk.STOCK_MEDIA_PLAY, gtk.ICON_SIZE_BUTTON))
            self.playing = False

    def setPause(self):
        self.log("setPause")
        """ display the pause image """
        if not self.playing:
            self.set_image(gtk.image_new_from_stock(gtk.STOCK_MEDIA_PAUSE, gtk.ICON_SIZE_BUTTON))
            self.playing = True
Comment 4 Alessandro Decina 2009-09-04 15:31:04 UTC
commit 24a13dae34de9c70bd51c39f1568454c4257dece
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Fri Sep 4 17:28:26 2009 +0200

    Force the play button to be visible, regardless of the gtk-button-images set
ting.