GNOME Bugzilla – Bug 593424
Disable font autoinstallation for terminal
Last modified: 2021-06-10 20:00:30 UTC
It's not that useful for terminal, and has high false positives (less a binary file). Should disable it. Can do it a few different ways: - Somehow convince GTK+ to not load the packagekit module, - After gtk_init, just install a brand new pango fontmap, or just use a new fontmap in vte widget. Donno. - Add a generic way to disable it in the module itself. An env var is ugly though, donno.
I think the 3rd option makes the most sense. Agreed that an env var does sound ugly. There are other ways to communicate with the module. E.g. through g_object_set_data() with a specific key on the fontmap. Or the module could install a GtkSetting that the app can query for and set.
On the other hand, vte widget in gedit will have a problem if we disable it all, or don't at all. The only case to resolve that one is to make vtepangocairo.c create and use a brand new pango font map. That however is not clean to implement either since we get the fontmap from the context that we get from the gdkscreen. However, since we are doing caching there, we make fixed assumptions on what in the context gdk actually does set, so we may as well get those and create our own context. The extra cost is actually not *that* bad. Humm, however, then we have to add code to allow online font installation since that is currently done by gtk+ on the default fontmap. Doh. Lemme think about it a bit more.
We should fix this ASAP, even if as a hack. I get too many reports about it in Fedora.
*** Bug 675174 has been marked as a duplicate of this bug. ***
(In reply to comment #3) > We should fix this ASAP, even if as a hack. I get too many reports about it in > Fedora. We have had a hack for it in gnome-packagekit for a while in the form of a blacklist. It needed updating. See bug 742873
Wouldn't it be better if the module simply did nothing in this case, instead of ignoring the dbus call after it happens, on the other side? The module could simply check g_get_prgname() == "gnome-terminal-server". Also this doesn't inhibit the module for other vte-using programmes, so a more generic way to inhibit the module per programme (or per widget, better!) is still required.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/6883.