After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593158 - When we need to reconnect an account, instead of disconnecting and reconnecting it, tp_cli_account_call_reconnect should be used.
When we need to reconnect an account, instead of disconnecting and reconnecti...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-26 13:19 UTC by Jonathan Tellier
Modified: 2009-08-27 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/reconnect-account (5.99 KB, patch)
2009-08-26 13:20 UTC, Jonathan Tellier 		committed Details | Review

Description Jonathan Tellier 2009-08-26 13:19:08 UTC 
When changes are applied to an account, it is disconnected and reconnected to validate the modifications on the server. Instead, tp_cli_account_call_reconnect should be used.
Comment 1 Jonathan Tellier 2009-08-26 13:20:06 UTC 
Created attachment 141749 [details] [review]
Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/reconnect-account

 libempathy-gtk/empathy-account-widget.c |   63 +++++++++++++------------------
 libempathy/empathy-account.c            |   43 +++++++++++++++++++++
 libempathy/empathy-account.h            |    7 +++
 3 files changed, 76 insertions(+), 37 deletions(-)
Comment 2 Cosimo Cecchi 2009-08-26 18:01:28 UTC 
Comment on attachment 141749 [details] [review]
Branch containing the proposed fix: http://git.collabora.co.uk/?p=user/jtellier/empathy.git;a=shortlog;h=refs/heads/reconnect-account

Looks good to me.
Comment 3 Guillaume Desmottes 2009-08-27 13:42:19 UTC 
I merged the branch as Jonathan doesn't have git account.
Jonathan: you could consider to request one btw :)

Thanks guys!