After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593042 - Don't hide controls in fullscreen when mouse is on top of it
Don't hide controls in fullscreen when mouse is on top of it
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-08-25 17:19 UTC by Kamil Páral
Modified: 2009-11-19 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for this bug (3.33 KB, patch)
2009-09-11 15:18 UTC, Maxim Ermilov
none Details | Review

Description Kamil Páral 2009-08-25 17:19:56 UTC
There is one little annoyance when playing movies with Totem in fullscreen. When you move a mouse, the controls appear, when you wait a while, they disappear - that is good! The problem is that they disappear also when you have your mouse currently *over the controls itself*. That should not happen. When I move mouse over the controls, it means I want them to stay where they are, visible. Controls should not disappear under your hands.

There is one use case I stumble upon very often - frequently I would like to watch video in fullscreen but at the same time I would like to see progressbar. It makes sense for some short clips, when watching various documentation, etc. With Totem this behaviour is currently impossible. Even when I force the controls to appear and move mouse over them, they again disappear.

Please change Totem's fullscreen behaviour to hide controls only when mouse cursor is over the video, not over the controls itself.
Comment 1 Bastien Nocera 2009-09-03 16:41:06 UTC
This code got lost when we moved the fullscreen code to share it with the browser plugin. The code lives in src/totem-fullscreen.c

One would need to receive the "enter-notify-event" and "leave-notify-event" events for the 2 popup windows, disable the popdown timeout when the cursor entered the popup, and re-enable it when it leaves.
Comment 2 Maxim Ermilov 2009-09-11 15:18:20 UTC
Created attachment 142992 [details] [review]
Patch for this bug
Comment 3 Philip Withnall 2009-09-12 16:25:14 UTC
(In reply to comment #2)
> Created an attachment (id=142992) [details]
> Patch for this bug

Shouldn't you also be re-enabling the popdown timeout (with totem_fullscreen_popup_timeout_add()) when the cursor leaves the popup, as Bastien said?
Comment 4 Maxim Ermilov 2009-09-12 17:56:59 UTC
> Shouldn't you also be re-enabling the popdown timeout (with
> totem_fullscreen_popup_timeout_add()) when the cursor leaves the popup, as
> Bastien said?

This does not necessarily to do. totem_fullscreen_popup_timeout_add will be calling in totem_fullscreen_motion_notify.
Comment 5 Bastien Nocera 2009-11-19 14:35:39 UTC
I moved the initial setting of pointer_on_control to _init()
as should be done for objects.