After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593024 - regression in schroenc streamheader initialization
regression in schroenc streamheader initialization
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2009-08-25 15:03 UTC by Arek Korbik
Modified: 2009-08-25 23:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch to set offset and offset_end on the header buffer (887 bytes, patch)
2009-08-25 15:03 UTC, Arek Korbik
committed Details | Review

Description Arek Korbik 2009-08-25 15:03:18 UTC
Created attachment 141654 [details] [review]
patch to set offset and offset_end on the header buffer

schroenc element doesn't set OFFSET and OFFSET_END correctly on the
streamheader buffers. That causes a problem if there's a multifdsink with a
pair of gdppay + gdpdepay between the schroenc and oggmux - oggmuxer will just
keep buffering output page buffers.

The following pipeline illustrates the problem; the fakesink will only receive
a single data buffer, while it should receive more.

gst-launch-0.10 -v videotestsrc ! schroenc ! gdppay ! tcpserversink port=13524
recover-policy=1 & sleep 1; gst-launch-0.10 -v tcpclientsrc port=13524 !
gdpdepay ! oggmux ! fakesink

Attaching a patch to set the dirac header buffer's OFFSET and OFFSET_END
according to the expectations of the oggmux.
Comment 1 Tim-Philipp Müller 2009-08-25 23:31:41 UTC
Thanks, committed (please provide a patch in 'git format-patch' format next time, so I don't have to type in the author and commit message myself, thanks):

 commit f1c4bdf5be57c95defcbfe735c94664e0ec4db65
 Author: Arek Korbik <>
 Date:   Wed Aug 26 00:26:42 2009 +0100

    schroenc: set right OFFSET and OFFSET_END on header buffers to make oggmux happy
    Without this oggmux will just keep buffering output pages in some cases.
    Fixes #593024.

Hardly a regression though seeing that we didn't ship these elements before ;)