GNOME Bugzilla – Bug 593024
regression in schroenc streamheader initialization
Last modified: 2009-08-25 23:34:11 UTC
Created attachment 141654 [details] [review]
patch to set offset and offset_end on the header buffer
schroenc element doesn't set OFFSET and OFFSET_END correctly on the
streamheader buffers. That causes a problem if there's a multifdsink with a
pair of gdppay + gdpdepay between the schroenc and oggmux - oggmuxer will just
keep buffering output page buffers.
The following pipeline illustrates the problem; the fakesink will only receive
a single data buffer, while it should receive more.
gst-launch-0.10 -v videotestsrc ! schroenc ! gdppay ! tcpserversink port=13524
recover-policy=1 & sleep 1; gst-launch-0.10 -v tcpclientsrc port=13524 !
gdpdepay ! oggmux ! fakesink
Attaching a patch to set the dirac header buffer's OFFSET and OFFSET_END
according to the expectations of the oggmux.
Thanks, committed (please provide a patch in 'git format-patch' format next time, so I don't have to type in the author and commit message myself, thanks):
Author: Arek Korbik <email@example.com>
Date: Wed Aug 26 00:26:42 2009 +0100
schroenc: set right OFFSET and OFFSET_END on header buffers to make oggmux happy
Without this oggmux will just keep buffering output pages in some cases.
Hardly a regression though seeing that we didn't ship these elements before ;)