Created attachment 141231 [details]
Screenshot

This is voluntary, it has been discussed in bug 591247.

> <mpt> fredp, yes, I think IM statuses should count as objects
> <mpt> (and therefore have icons)

IM statuses for sure, but the "Edit Custom Messages..." is not a status, it's an action like "save" or "open". I'm quite sure mpt would agree :)

Oh right, didn't click on your screenshot :)

Ok, I got confused as you're not talking about the menu that appears when right clicking on the status icon, which has an "edit custom messages..." that should respect global policy, and the presence chooser in the main window, which is *not* a menu but a treeview.

This makes it relatively difficult to fix it correctly, as it needs code to listen to the global gconf property, and update a treeview item on changes...

The "wrong" fix is however quite easy, removing the icon permanently could be done by this simple fix to presence_chooser_create_model():

        gtk_list_store_insert_with_values (store, NULL, -1,
                COL_STATUS_TEXT, _("Edit Custom Messages..."),
-               COL_STATE_ICON_NAME, GTK_STOCK_EDIT,
+               COL_STATE_ICON_NAME, "",
                COL_DISPLAY_MARKUP, _("Edit Custom Messages..."),
                COL_TYPE, ENTRY_TYPE_EDIT_CUSTOM,
                -1);

*** Bug 592853 has been marked as a duplicate of this bug. ***

(In reply to comment #5)
> This makes it relatively difficult to fix it correctly, as it needs code to
> listen to the global gconf property, and update a treeview item on changes...

Indeed that's what we should do.

> The "wrong" fix is however quite easy, removing the icon permanently could be
> done by this simple fix to presence_chooser_create_model():
> 
>         gtk_list_store_insert_with_values (store, NULL, -1,
>                 COL_STATUS_TEXT, _("Edit Custom Messages..."),
> -               COL_STATE_ICON_NAME, GTK_STOCK_EDIT,
> +               COL_STATE_ICON_NAME, "",
>                 COL_DISPLAY_MARKUP, _("Edit Custom Messages..."),
>                 COL_TYPE, ENTRY_TYPE_EDIT_CUSTOM,
>                 -1);

I don't like that patch. IMO we should respect the value of that gconf key. I personally don't like removing all icons. For menus I know, I can find the line I want just by a quick look to icons, and don't read text anymore...

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/106.