GNOME Bugzilla – Bug 592410
Take advantage of Unicode
Last modified: 2018-05-24 14:32:00 UTC
There are various places in Rhythmbox where three dots ("...") are being used instead of a proper ellipsis character ("…"). Patch coming to use the correct character instead.
Created attachment 141215 [details] [review] Use proper ellipses
Created attachment 336697 [details] [review] Use Unicode in translatable strings Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Created attachment 349370 [details] [review] Use Unicode in translatable strings Rebased on current master.
(In reply to Piotr Drąg from comment #3) > Created attachment 349370 [details] [review] [review] > Use Unicode in translatable strings > > Rebased on current master. Patch still works fine with offsets without issues. But. why are the single quotes replaced with LEFT DOUBLE QUOTATION MARK ( U+201C ) and RIGHT DOUBLE QUOTATION MARK ( U+201D ), rather than LEFT SINGLE QUOTATION MARK ( U+2018 ) and RIGHT SINGLE QUOTATION MARK ( U+2019 )
(In reply to Piotr Drąg from comment #3) > Created attachment 349370 [details] [review] [review] > Use Unicode in translatable strings Also, the encoding of source files needs to be updated to 'utf-8' in header comments. Please refer to patch below.
Created attachment 364001 [details] [review] take advantage of unicode: use u+2236 ( ratio ) rather than colon[:] This patch applies independently of the above submitted patch.
(In reply to gkrithi8 from comment #4) > (In reply to Piotr Drąg from comment #3) > > Created attachment 349370 [details] [review] [review] [review] > > Use Unicode in translatable strings > > > > Rebased on current master. > > Patch still works fine with offsets without issues. > > But. why are the single quotes replaced with LEFT DOUBLE QUOTATION MARK ( > U+201C ) and RIGHT DOUBLE QUOTATION MARK ( U+201D ), rather than LEFT SINGLE > QUOTATION MARK ( U+2018 ) and RIGHT SINGLE QUOTATION MARK ( U+2019 ) FWIW, I think the single quotes and double quotes in code are better left off at their current state. The unicode replacement doesn't look any better, though it might confirm to the standards.
(In reply to gkrithi8 from comment #4) > But. why are the single quotes replaced with LEFT DOUBLE QUOTATION MARK ( > U+201C ) and RIGHT DOUBLE QUOTATION MARK ( U+201D ), rather than LEFT SINGLE > QUOTATION MARK ( U+2018 ) and RIGHT SINGLE QUOTATION MARK ( U+2019 ) Double quotation marks are almost always preferable in English, and it’s what was codified in GNOME HIG. (In reply to gkrithi8 from comment #7) > FWIW, I think the single quotes and double quotes in code are better left > off at their current state. The unicode replacement doesn't look any better, > though it might confirm to the standards. Obviously, I disagree.
Created attachment 364009 [details] [review] Use Unicode in translatable strings • Rebased on master. • Replaced colons with proper ratio characters. • Added “coding: utf-8” to existing modelines.
Comment on attachment 364001 [details] [review] take advantage of unicode: use u+2236 ( ratio ) rather than colon[:] this change is included in the main patch. so marking as obsolete.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/789.