After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592063 - [skin] restore GNOME logo in header
[skin] restore GNOME logo in header
Status: RESOLVED FIXED
Product: bugzilla.gnome.org
Classification: Infrastructure
Component: layout
unspecified
Other All
: Normal normal
: ---
Assigned To: Bugzilla Maintainers
Bugzilla Maintainers
Depends on: 742338
Blocks:
 
 
Reported: 2009-08-17 12:21 UTC by Frederic Peters
Modified: 2017-03-01 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
changes to skin, and mini gnomelook extension (3.62 KB, patch)
2009-08-17 12:22 UTC, Frederic Peters
none Details | Review
Fixed CSS (3.62 KB, patch)
2009-08-17 12:28 UTC, Frederic Peters
none Details | Review
Fixes footer width, and add goboom (4.19 KB, patch)
2009-08-17 12:33 UTC, Frederic Peters
none Details | Review
how I thought it looked. (21.21 KB, image/png)
2009-09-12 11:36 UTC, Frederic Peters
  Details
Adds GNOME logo in header (18.73 KB, patch)
2016-10-31 21:15 UTC, Tom Tryfonidis
none Details | Review
Screenshot with the GNOME logo on header (253.67 KB, image/png)
2017-01-20 14:32 UTC, Tom Tryfonidis
  Details
GNOME logo on header (13.81 KB, patch)
2017-02-25 20:59 UTC, Tom Tryfonidis
accepted-commit_now Details | Review
Screenshot showing the changes from patch 346719 (56.34 KB, image/png)
2017-02-25 21:01 UTC, Tom Tryfonidis
  Details

Description Frederic Peters 2009-08-17 12:21:37 UTC
The following attachment provides:

 * changes to the global CSS file, to match what was on the old
   bugzilla.gnome.org (a 48px solid banner, and a GNOME foot in the top
   left corner)

 * a new "gnomelook" extension, that changes the footer to include
   a "Hosted by Red Hat" paragraph (maybe it's overkill to put this in an
   extension and it would better be in template/en/custom/)
Comment 1 Frederic Peters 2009-08-17 12:22:12 UTC
Created attachment 140956 [details] [review]
changes to skin, and mini gnomelook extension
Comment 2 Frederic Peters 2009-08-17 12:28:40 UTC
Created attachment 140957 [details] [review]
Fixed CSS

The CSS in the previous patch was wrong (the GNOME logo was set as "fixed" not "absolute").
Comment 3 Frederic Peters 2009-08-17 12:33:08 UTC
Created attachment 140958 [details] [review]
Fixes footer width, and add goboom

Another quick fix to fix the width of the footer, and to add goboom to the index page.
Comment 4 Olav Vitters 2009-09-10 08:38:34 UTC
The 48px banner is not what the old GNOME Bugzilla looked like. Rather, see e.g. http://live.gnome.org/.
Comment 5 Frederic Peters 2009-09-12 11:36:39 UTC
Created attachment 143050 [details]
how I thought it looked.

Did it?  I thought bugzilla.gnome.org was the last of gnome site to still use a 48px header?

Would you have a screenshot of the old look?  (I searched my local screenshots and google without success)
Comment 6 Olav Vitters 2009-09-12 11:40:45 UTC
You're totally right. Just thought you were using that very old layout.

Would still appreciate a newer look, but not sure if that is easily possible.
Comment 7 Frederic Peters 2009-09-12 13:35:08 UTC
It's possible but it requires some heavy changes to the templates, also there is a new look in the (definitely future) www.gnome.org plone website so I don't think those important changes are worth it at the moment.
Comment 8 André Klapper 2015-01-03 14:50:32 UTC
Probably needs another round of adjustment if we upgrade to 4.4...
Comment 9 André Klapper 2015-01-04 20:53:01 UTC
If we have a custom skin, the cheapest version to have a GNOME logo is to put it into the very first line, via a custom skin file "global.css":

    #titles #title {
        font-weight: bold;
        white-space: nowrap;
        background: url(./images/favicon.png) center left no-repeat;
        padding-left: 17px;
        left: 0;
    }

and that favicon can be an inverted version so it's more white than black on that dark blue background of the standard theme that bugzilla-test (4.4) currently has.
Comment 10 André Klapper 2015-01-18 01:01:40 UTC
@fredp: Can we safely set your patch to "needs-rework"? I don't see this easily applying with 4.4 around the corner. Cleaning up the backlog...
Comment 11 Tom Tryfonidis 2016-10-31 21:15:53 UTC
Created attachment 338854 [details] [review]
Adds GNOME logo in header

The patch is based in 4.4.12 version of bugzilla.
Comment 12 Andreas Nilsson 2017-01-20 13:48:01 UTC
(In reply to Tom Tryfonidis from comment #11)
> Created attachment 338854 [details] [review] [review]
> Adds GNOME logo in header
> 
> The patch is based in 4.4.12 version of bugzilla.

Do you have a screenshot of that in action?
Comment 13 Tom Tryfonidis 2017-01-20 14:32:23 UTC
Created attachment 343906 [details]
Screenshot with the GNOME logo on header

A compined screenshot that shows the homepage and the redesigned sidebar on product overview.
Comment 14 Tom Tryfonidis 2017-02-25 20:59:14 UTC
Created attachment 346719 [details] [review]
GNOME logo on header

Reworked patch to match the current design and colors of gnome.org
Comment 15 Tom Tryfonidis 2017-02-25 21:01:25 UTC
Created attachment 346720 [details]
Screenshot showing the changes from patch 346719
Comment 16 Tom Tryfonidis 2017-03-01 09:32:20 UTC
Thank you for accepting my patch. It lives on master and production branches now.