After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591984 - + Button should be hittable slightly beneath as well
+ Button should be hittable slightly beneath as well
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 593429 594639 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-08-16 17:04 UTC by Turbo
Modified: 2009-09-09 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Extend (+) button sensitivity to corner of screen, for Fittsability (2.01 KB, patch)
2009-09-09 13:49 UTC, Dan Winship
accepted-commit_now Details | Review
Extend (+) button sensitivity to corner of screen, for Fittsability (1.92 KB, patch)
2009-09-09 15:31 UTC, Dan Winship
committed Details | Review

Description Turbo 2009-08-16 17:04:01 UTC
The + button should have some kind of "aurora" (so clicking slightly
beneath the button should still hit it).
Comment 1 Owen Taylor 2009-08-28 19:46:24 UTC
*** Bug 593429 has been marked as a duplicate of this bug. ***
Comment 2 Owen Taylor 2009-08-28 19:47:04 UTC
Bug 593429 suggests that the hittable (and droppable) area should extend all the way to the corner.
Comment 3 Frederic Peters 2009-09-09 13:00:53 UTC
*** Bug 594639 has been marked as a duplicate of this bug. ***
Comment 4 Dan Winship 2009-09-09 13:49:37 UTC
Created attachment 142790 [details] [review]
Extend (+) button sensitivity to corner of screen, for Fittsability
Comment 5 Dan Winship 2009-09-09 13:54:50 UTC
er... the "let global..." addition is a mistake obviously
Comment 6 Owen Taylor 2009-09-09 14:57:37 UTC
Review of attachment 142790 [details] [review]:

Looks good, couple of tiny comments.

::: js/ui/overview.js
@@ -441,1 +441,3 @@
+        let global = Shell.Global.get();
+
         global.screen.append_new_workspace(false, global.screen.get_display().get_current_time());

Some bad merge with your global removal?

@@ -465,0 +466,3 @@
+
+        let plus = new Clutter.Texture({ width: buttonSize,
+                                         height: buttonSize });

Not sure I like relying on the default 0,0 position - position doesn't seem to me like something that has a natural default for an absolutely positioned actor - the fact that you are positioning at the upper left of the group and 0,0 owrks is more an accident of screen layout then something inherent.
Comment 7 Dan Winship 2009-09-09 15:31:51 UTC
The following fix has been pushed:
a0df412 Extend (+) button sensitivity to corner of screen, for Fittsability
Comment 8 Dan Winship 2009-09-09 15:31:54 UTC
Created attachment 142797 [details] [review]
Extend (+) button sensitivity to corner of screen, for Fittsability
Comment 9 William Jon McCann 2009-09-09 16:28:48 UTC
Actually the button should be under the bottom of the last workspace as in:
http://live.gnome.org/GnomeShell/DesignerPlayground/AppBrowsingAlternative02?action=AttachFile&do=view&target=shell03.png

We want to leave room for the message tray at the bottom of the screen I think.