GNOME Bugzilla – Bug 591953
Rewrite of the build system
Last modified: 2009-10-09 11:08:49 UTC
These 4 patches rewrite the build system of evolution exchange. They gave me the same results than before (checked config.log) and make check ran fine. They include the following changes : -> # replaced by dnl, comments added -> add of an m4 folder -> rewrote initialization of AutoConf & AutoMake -> don't use pkg-config directly, use ${PKG-CONFIG} ----> this required the rearrangement of a few things as ${PKG-CONFIG} is set by PKG_PROG_PKG_CONFIG ---------> versions / programs / compiler flags / win32 check / pkg-config / versioning [evo/eds] etc. -> rewrite the tests so no deprecated macros are used -> Check that eds was built with Exchange : Don't use echo / exit, let if fail with AC_MSG_ERROR -> use if's instead of case's when possible -> whitespace fixes
Created attachment 140874 [details] Patches for Exchange
Created attachment 140925 [details] [review] Reworks comments
Created attachment 140926 [details] [review] Fixes initialization of autoconf/-make and m4 folder step 1
Created attachment 140927 [details] [review] delete of acinclude.m4 and necessary macros
Created attachment 140928 [details] [review] Rewrote of configure.ac Sorry for putting this in twice, but I had trouble uploading patches this afternoon. As it now works and I think it's easier to have the patches then the compressed file, I put this in now as it works. The compressed file contains the same files!
tearofadragon: This is not a blocker for GNOME 2.30. Please use the Tragte Milestone field instead.
I didn't check patches myself, but as we spoke or IRC, I just finished my changes to eex, even the bug #456240 is still pending. When it'll be done, please obsolete all your patches and upload only one (even large) uncompressed patch, for better operability. Thanks in advance.
Created attachment 145006 [details] [review] Rewrites the whole buildsystem Hi... Well... As you can obviously see, in this patch there's a whole more than before. I tried to ran make distcheck and it completely failed, thus I've checked very careful the whole buildsystem and found more then one bug: a) rewrite docs/reference/Makefile.am : Use top_srcdir gtk.make which gets copied by gtkdocize b) include checks in autogen.sh c) rewrite configure.ac d) rewrite Makefiles -> per-target flags f) M4 files g) doc fixes h) PO fixes (include eplugin) and I think a few more - sorry that it became so much more invasive, however it should be finished. I tested carefully and make distcheck worked for me, however I guess that due to it's big changes there might be some caveats still lying.
Created attachment 145030 [details] [review] Updated patch - includes m4 macros Forgot to include the macros in m4 - added them in this patch, sorry.
I just uploaded some massive Evolution-Exchange changes to move over the storage server code from Evolution-Data-Server. You might want to check my work and see what I've broken. Meantime, I'll try to adapt your patch to the changes I've made.
Created attachment 145086 [details] [review] Revised patch Updated patch for current git master. Look over the changes and make sure I got everything -- especially in configure.ac, as that required significant manual editing. Also look over the Kerberos stuff in configure.ac, if you would. I applied an older patch and I think it's missing some of your Kerberos changes from E-D-S.
mbarnes, I asked in IRC for direct pull and got okay of mcrha. Fixed a few things and think it should work. I've modified the Berkeley DB check so that it fails if Berkeley DB isn't found like it is in EDS... I've updated the Kerberos check to include the latest from EDS, a few typos and a change that mcrha proposed. http://git.gnome.org/cgit/evolution-exchange/commit/?id=2721f837044dffb956053df372868e3511bafcda