After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591873 - Orca doesn't speak tooltips in OOo
Orca doesn't speak tooltips in OOo
Status: RESOLVED NOTGNOME
Product: orca
Classification: Applications
Component: speech
2.27.x
Other All
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404411
 
 
Reported: 2009-08-15 04:58 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2010-05-22 18:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
possible solution (2.08 KB, patch)
2009-08-15 05:11 UTC, Joanmarie Diggs (IRC: joanie)
reviewed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-08-15 04:58:48 UTC
This is a spin-off bug from bug 590680.

Ctrl+F1 can be used to show the tooltip for items in OOo toolbars. Orca fails to present the tooltip.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-15 05:11:12 UTC
Created attachment 140825 [details] [review]
possible solution

The problem is that when OOo tooltips appear, an object:state-changed:visible event is emitted; an object:state-changed:showing is not. We expect the latter and are not even listening for the former.

This patch adds a listener to the OOo script. Problem solved.

Will: As I understand it, and based on testing this patch: The addition of the listener in the OOo script means that all scripts which are active while OOo is being used will listen for this new event. Once the user quits OOo, all of the other scripts will stop listening for it. (Right?) If so, is this event one which we'd prefer not to be listening to? (i.e. would you rather I file a bug against OOo and block this one?)

Thanks!
Comment 2 Willie Walker 2009-08-17 15:43:14 UTC
(In reply to comment #1)
> Will: As I understand it, and based on testing this patch: The addition of the
> listener in the OOo script means that all scripts which are active while OOo is
> being used will listen for this new event. Once the user quits OOo, all of the
> other scripts will stop listening for it. (Right?)

Short answer: correct.  Long answer: when any script instance listens for an event, Orca will get the event notification regardless of whether the script is the active script or not. When a script instance goes away, the focus_tracking_presenter should deregister events. If there is no other script listening for an event after this happens, then the event should not be delivered to Orca.

> If so, is this event one
> which we'd prefer not to be listening to? (i.e. would you rather I file a bug
> against OOo and block this one?)

Some events are quite quite chatty.  I believe the bounds-changed one in particular is pretty nasty.  I'm not sure about visible, though.  It might be one of those that's up there with the child added/deleted events, but the best way would be to run some regression tests and grep the debug logs for the event.

Since this one is kind of an unknown and may introduce an unexpected performance penalty, I'm tempted to push this one out to 2.29.0 as well.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-08-17 15:58:56 UTC
Sounds like a plan. I've just opened an enhancement request asking them to consider emitting an object:state-changed:showing event at the same time they're emitting the object:state-changed:visible event. Maybe they'll say "yes". <fingers crossed>

In the meantime, I'm blocking this bug against that request.
Comment 4 Joanmarie Diggs (IRC: joanie) 2010-04-02 21:22:08 UTC
Changing the status from 'blocked' to 'to verify' because the blocking bugs are
marked as fixed.

Note: Verification doesn't necessarily mean that Orca is doing the right thing
yet; merely that in theory we should be able to implement what we need to do
because we're getting the expected events and/or other information from OOo.
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-04-17 03:32:44 UTC
Cannot verify this yet. The bug still exists in OOo dev 3.3 m76. But based on experience, it takes a few dev builds for these changes to get incorporated into an externally-available build.
Comment 6 Joanmarie Diggs (IRC: joanie) 2010-05-22 18:49:51 UTC
Verified in OOo dev 3.3 m78. Orca now presents the tooltips as expected when Ctrl+F1 is pressed. Since there is no need for us to change anything in Orca, closing this bug as NOTGNOME.