After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591871 - Orca says "off" for all push buttons on the OOo toolbars and doesn't say "on" when it should
Orca says "off" for all push buttons on the OOo toolbars and doesn't say "on"...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.27.x
Other All
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
http://www.openoffice.org/issues/show...
: 590680 (view as bug list)
Depends on:
Blocks: 404411
 
 
Reported: 2009-08-15 03:40 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-01-07 14:44 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
proposed fix (6.83 KB, patch)
2009-08-15 03:52 UTC, Joanmarie Diggs (IRC: joanie) 		rejected Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-08-15 03:40:22 UTC 
This is a spin-off bug from bug 590680.

1. We say "off" for all push buttons on the OOo toolbars; not just the formatting buttons. If a user is exploring the toolbar, all of those "offs" will rapidly become... well... off-putting. :-)

2. If a user happens to be on the toolbar and presses an object of ROLE_PUSH_BUTTON and that object emits an object:state-changed:checked event, we present nothing.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-15 03:52:41 UTC 
Created attachment 140824 [details] [review]
proposed fix

This gets rid of the off-putting offs and causes us to announce when the user is on a push button and that push button emits an object:state-changed:checked event.

In the latter case, if detail1 == 1, we say 'on' at the end (Bold on). If detail1 == 0, we do not say 'off' (Bold). Note that we *do* continue to say 'on' as well as 'off' if the user is not on the button, for instance when pressing Ctrl+B while editing a document. This patch only impacts what happens when the user is physically on the toolbar button which we are presenting.

Will please review. Thanks!
Comment 2 Willie Walker 2009-08-17 14:49:26 UTC 
Comment on attachment 140824 [details] [review]
proposed fix

When navigating the toolbar, it wasn't obvious to me that I would only hear "on" if the feature was set. :-(  As a result, I thought Orca was misspeaking when it said "Bold" when I landed on the bold button -- to me, it sounded like Orca was telling be "Bold" had been set.

So, I'm not sure I really agree that eliminating 'off' is the right thing to do.  If anything, perhaps it should be turned off only if the verbosity level is set to brief.

Since this also represents kind of significant change in how we present the toolbar, I'd also say we push this out to 2.29.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-08-17 15:04:51 UTC 
Okie dokie. If we're going to push it off, then really what we should do is not do this patch, but file a bug against OpenOffice so that push buttons are push buttons and toggle buttons are toggle buttons. I'll do that. And as soon as I can work out where the status for my patch can be changed, I'll reject it. :-)
Comment 4 Joanmarie Diggs (IRC: joanie) 2009-08-17 15:44:03 UTC 
http://www.openoffice.org/issues/show_bug.cgi?id=104293 has been opened so that we will get the proper role. Then we can say "off" for toggle buttons which are not checked and not say "off" for push buttons.

Blocking this bug and retargeting for FUTURE as we have little control over the bugs that block us.
Comment 5 Joanmarie Diggs (IRC: joanie) 2009-08-24 16:03:45 UTC 
*** Bug 590680 has been marked as a duplicate of this bug. ***
Comment 6 Joanmarie Diggs (IRC: joanie) 2010-09-14 11:27:01 UTC 
The blocking bug is fixed. We just need to make the corresponding change on our end.

Note to self while I'm thinking about it: This change, once made, should NOT be put back in 2.32.1 because users will likely not have the OOo fix in question.