After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591734 - [testing required] "No break space" character not spoken
[testing required] "No break space" character not spoken
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
unspecified
Other All
: Normal normal
: 2.28.0
Assigned To: Willie Walker
Orca Maintainers
: 591724 (view as bug list)
Depends on:
Blocks: 404409
 
 
Reported: 2009-08-13 18:49 UTC by Willie Walker
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.85 KB, patch)
2009-08-15 00:53 UTC, Willie Walker
committed Details | Review

Description Willie Walker 2009-08-13 18:49:44 UTC
From http://mail.gnome.org/archives/orca-list/2009-August/msg00196.html:

"Probably this is related to thunderbird but I decided to report so that someone can confirm.

To reproduce try the following:

1. Create a new message using thunderbird.

2. In the body of the message type the following text:
"This   is   a   test"
Without the quotations.
You must type 3 (three) blanks between each word.

3. Try to review the text using the left and right keys.

Note that some spaces are not announced."
Comment 1 Willie Walker 2009-08-13 19:09:29 UTC
I was able to reproduce this using the HTML-mode of Thunderbird for entering text.  The problem is indeed the no-break space character.  Adding the following to chnames.py resolves the problem:

chnames[u'\u00a0'] = _("no break space")

I think there is value in letting someone know there is a no-break space there, since it provides different behavior when it comes to wrapping.  But, I'm willing to acquiesce if people would rather hear "space" than "no break space".  It would also prevent the need for me to send out a string change notice.

Comment 2 Willie Walker 2009-08-13 19:34:23 UTC
Note that the fix for this should probably also translate all no-break space characters to spaces in the string just before it is sent to the synthesis engine.  Otherwise, the synthesis engine may interpret the no-break space character as something else.
Comment 3 Willie Walker 2009-08-15 00:53:40 UTC
Created attachment 140821 [details] [review]
Patch

This patch does two things (hopefully):

1) When reviewing by character, you will hear "no break space"

2) When reviewing by any other means (say all, line, etc.), it should substitute a normal space for the no break space character

In no case (hopefully) should the no break space character itself be sent to the synthesis engine.

Please test by navigating by character, navigating by line, doing a SayAll, etc.
Comment 4 Jose Vilmar Estacio de Souza 2009-08-15 01:58:29 UTC
Tested and approved, works fine.
Many many thanks for this fix.
Finally I can stop fighting with my friend Ciro. He always sends me messages with more than one blank between the words and it was difficult to read them.
Comment 5 Paul Hunt 2009-08-15 12:01:21 UTC
Hi Will.  This works perfectly!  It also solves the related 'double speaking of punctuation symbols' problem.  thanks.
Comment 6 Jose Vilmar Estacio de Souza 2009-08-15 15:12:15 UTC
When reviewing the message line by line, lines with only one space are read as NoBreakSpace. 
Doesn't happen when reading the entire document.
Comment 7 Willie Walker 2009-08-17 14:15:31 UTC
Comment on attachment 140821 [details] [review]
Patch

Committed to git master for 2.27.91.  Thanks for testing!
Comment 8 Willie Walker 2009-08-20 21:18:50 UTC
*** Bug 591724 has been marked as a duplicate of this bug. ***
Comment 9 Olivier BERT 2009-10-15 21:33:31 UTC
Resolves all the pronunciation issues I had using the ibmtts speech engine. 

Thanks