After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591730 - mutter forgets plugins when session saving
mutter forgets plugins when session saving
Status: RESOLVED DUPLICATE of bug 648828
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-13 18:17 UTC by Matthias Clasen
Modified: 2013-12-21 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
session: restore command line arguments on session restore (6.26 KB, patch)
2013-12-21 17:09 UTC, Ray Strode [halfline]
rejected Details | Review

Description Matthias Clasen 2009-08-13 18:17:23 UTC
I was running gnome-shell, and I have that stupid 'save session' checkbox on. After logging out and going back to the regular gnome session, I found that mutter had replaced metacity, but it was running with the default plugin, so I didn't notice it at first...
Comment 1 Josselin Mouette 2010-01-30 13:47:38 UTC
This is even worse if you save your session while running gnome-shell. There are two instances of mutter launched in this case, and the top panel never appears on the screen.

FIxing this properly will probably require to add session management support to gnome-shell itself, or at least a way to detect when mutter is already launched with the proper arguments.
Comment 2 Ray Strode [halfline] 2013-12-21 17:00:37 UTC
This has changed a bit now that mutter is a library instead of a binary, but the problem still exists.

if you save your session and are in classic mode then when you come back you'll be without classic mode.

This is because the RestartCommand  that is saved into the session fails to include the --mode that gnome-shell was started with.
Comment 3 Ray Strode [halfline] 2013-12-21 17:01:49 UTC
see also bug 648828
Comment 4 Ray Strode [halfline] 2013-12-21 17:09:53 UTC
Created attachment 264717 [details] [review]
session: restore command line arguments on session restore

gnome-shell changes behavior dramatically depending on what arguments
it was started with.  Concretely, if it's started with --mode=classic
it loads a completely different user experience than if it's started
without specifying a mode.

Since the command line arguments are an important part of the state
of gnome-shell, those command line arguments really need to be tucked
away on session save.

This commit makes sure to include the command line arguments in the
RestartCommand so state is properly restored.
Comment 5 Ray Strode [halfline] 2013-12-21 17:13:48 UTC
so i was going to suggest the above, but it doesn't really solve the problem, just flips the coin, I guess. Before if you saved when logged into classic mode you'd end up back in a non-classic session (since --mode=classic was stripped).  Now if you saved when logged into a classic session and try to pick a normal session from GDM you'll end up in a classic session (since --mode=classic is hard coded in the saved session).

I think we're going to need to add better smarts for classic versus non-classic.
Comment 6 Ray Strode [halfline] 2013-12-21 17:33:27 UTC
Comment on attachment 264717 [details] [review]
session: restore command line arguments on session restore

I think the real answer means not relying on the command line to set the session, since the command line gets saved in the session state and the session type can get changed form log in to log in independent of the saved sessino.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-12-21 17:35:42 UTC
Can we just deprecate and remove session saving?
Comment 8 Ray Strode [halfline] 2013-12-21 17:47:29 UTC
Since my understanding of my issue has changed so much i'm not not going to hijack this bug anymore.  This report is really just a duplicate of bug 648828

*** This bug has been marked as a duplicate of bug 648828 ***
Comment 9 Ray Strode [halfline] 2013-12-21 17:50:27 UTC
(In reply to comment #7)
> Can we just deprecate and remove session saving?

Not really, the window manager plays an important part of the XSMP, so dropping  it completely would break XSMP.  Aside from that, i need the feature for RHEL 7 based on customer demand.