GNOME Bugzilla – Bug 591610
asfmux: messing up with sinkpads
Last modified: 2009-08-12 22:33:29 UTC
asfmux might mess up sinkpads when it writes indexes because it sorts the GstCollectData list in GstCollectPads (because the spec wants video pads in stream number order). While developing it I assumed the g_slist_reverse would create a new list, but it doesn't.
As a result, some of the GstCollectData might be lost and the muxer will use only the remaining ones to compute media duration and other fields.
The solution is to copy the list and then reverse it.
Created attachment 140592 [details] [review]
Fixes the problem
Makes sense, please commit.
Author: Thiago Santos <email@example.com>
Date: Wed Aug 12 18:33:22 2009 -0300
asfmux: Do not mess up GstCollectData list
asfmux was messing up with the GstCollectData list of its
GstCollectPads when sorting the list inplace. This patch makes
it copy the list before sorting it, leaving the GstCollectPads
list as is. Fixes #591610