After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591592 - Orca does not speak and braille the appropriate information when moving by headings on all sites
Orca does not speak and braille the appropriate information when moving by he...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.27.x
Other All
: Normal normal
: 2.28.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-08-12 18:38 UTC by Mike Pedersen
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
revision 1 (1.39 KB, patch)
2009-08-12 22:28 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
same code, new regression test added (5.87 KB, patch)
2009-08-12 23:45 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Mike Pedersen 2009-08-12 18:38:31 UTC
On the following site orca just speaks heading link and brailles the level.
1.  Go to http://wikis.sun.com/display/OpenSolarisInfo/How+To+Add+IPS+Repositories
2. repeatedly press "h" to move through the page.  

You should notice that when you land on several of the headings at level two and level three you don't hear or see in braille the actual heading information.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-12 21:48:38 UTC
Confirmed. We're seeing an anchor, treating it as a link, and grabbing focus on it as if it were a proper link.

<h2><a name="HowToAddIPSRepositories-AddingIPSRepositories"></a>Adding IPS Repositories</h2>

Taking this one for 2.27.91. Should be relatively easy.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-08-12 22:28:02 UTC
Created attachment 140595 [details] [review]
revision 1

I'm waiting (and waiting, and waiting) for a silly DayJob video to produce. So.... This seems to solve the problem. It's obviously not regression tested yet. I'll do that. In the meantime, it should be sound, therefore please test.

Thanks!
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-08-12 23:45:28 UTC
Created attachment 140599 [details] [review]
same code, new regression test added

Because the fix is limited to structural navigation, the only regression tests that might show any difference are the structural navigation tests (along with bug_589455.py). I ran all of those and they all passed.

Therefore, this version just adds a new regression test for this particular bug. Pylints to a 10, high impact/low risk, yadda, yadda, yadda.
Comment 4 Joanmarie Diggs (IRC: joanie) 2009-08-13 15:32:59 UTC
Since Will changed the status of my patch to accepted-commit_now (thanks!), I've done so. Closing as FIXED.