GNOME Bugzilla – Bug 591495
Use Pango markup attributes in GtkBuilder file
Last modified: 2009-12-26 13:49:13 UTC
The Pango markup from the "input_description" and "label3" labels in applet.ui should use Pango attributes as part of the GtkLabel definition, rather than as part of the translatable label text. This makes it less likely that translators will introduce markup mistakes and consequently break the interface. See here: http://library.gnome.org/devel/gtk/stable/GtkLabel.html#GtkLabel-BUILDER-UI
Also, "overview_label", "label7" and "label8" from stats.ui should make use of Pango attributes.
"label3", "label7" and "label2" from preferences.ui also need some love.
Created attachment 140493 [details] [review] Use Pango attributes in the GtkBuilder files This is untested. It should all work, though I'm not confident about the "Tell me more" pseudo-link in applet.ui. The best solution for this label would be to use the label link functionality introduced in GTK+ 2.18. Note that it bumps the GTK+ requirement from 2.12 to 2.14.
I'm somewhat concerned about bumping the gtk+ version - 2.14 is just a year ago.
Aren't we part of *this* years GNOME release? ;)
well then, let's try to get it in :) patch as it is causes segmentation fault of hamster on my box. i tried to adjust font size to small in the semi-button in applet dropdown using glade 3.6.3 and it does not seem to understand PANGO_SCALE_SMALL and the numeric values do not seem to have impact.
(In reply to comment #6) > patch as it is causes segmentation fault of hamster on my box. What's the backtrace?
I've just come across this in another module, and it's because PANGO_SCALE_* aren't defined in an enum (i.e. PangoScale doesn't exist). Accordingly, GtkBuilder can't parse PANGO_SCALE_SMALL. The patch should work if 0.83 is used instead.
Thanks Philip! I think most of the git master now uses attributes instead of markup. hamster.ui is safe to ignore as it is something that is not accessible from the UI for now anyway. thanks for report, i'm marking this as fixed now