GNOME Bugzilla – Bug 591450
Build related fixes
Last modified: 2009-11-25 22:19:27 UTC
Hi, I've made two patches : -> acinclude.m4 shouldn't be used if a m4 folder exists. Splitted the two macros out in the m4 folder. -> renamed configure.in to configure.ac. -> kills off whitespace in configure.ac and formats it. -> replace AC_HELP_STRING by AS_HELP_STRING. -> Makefile.am -> use ACLOCAL_AMFLAGS=-I m4 to include the macros -> replaced # by dnl
Created attachment 140439 [details] [review] Makefile.am changes & delete of configure.in
Created attachment 140440 [details] [review] delete of acinclude.m4 & splitted out macros & configure.ac
Created attachment 140443 [details] [review] Adds necessary macros to m4 folder ( really ) This adds the splitted out macros to the m4 folder. Forget them to include in patch 2.
Thanks for the patches! I am currently on vaccation but try and apply them right afterwards.
Sorry for late reply. I had some issues applying the first patch. I have committed it, but there is a small issue with "make distcheck" - any idea? make[1]: Entering directory `/home/ensonic/projects/gnome/gtk-doc/gtk-doc-1.12/_build' make[1]: Leaving directory `/home/ensonic/projects/gnome/gtk-doc/gtk-doc-1.12/_build' make[1]: Entering directory `/home/ensonic/projects/gnome/gtk-doc/gtk-doc-1.12/_build' { test ! -d gtk-doc-1.12 || { find gtk-doc-1.12 -type d ! -perm -200 -exec chmod u+w {} ';' && rm -fr gtk-doc-1.12; }; } test -d gtk-doc-1.12 || mkdir gtk-doc-1.12 cp: cannot create regular file `gtk-doc-1.12/m4/gnome-doc-utils.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/gtkdoc_jh_check_xml_catalog.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/gtkdoc_jh_path_xml_catalog.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/libtool.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/ltoptions.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/ltsugar.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/ltversion.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/lt~obsolete.m4': Permission denied make[1]: *** [distdir] Error 1 make[1]: Leaving directory `/home/ensonic/projects/gnome/gtk-doc/gtk-doc-1.12/_build' make: *** [distcheck] Error 2
This seems more like a problem that was created by yourself. Check the local rights on your folders if they are correct as they are copied by make distcheck. Maybe git clean -xdf [which resets the git tree to the last log entry] may help. At me everything runs perfect, make distcheck ran without any problems.
I definitely happens on all my computers: Making uninstall in . ... make[1]: Entering directory `/home/ensonic/projects/gnome/gtk-doc/gtk-doc/gtk-doc-1.12/_build' { test ! -d gtk-doc-1.12 || { find gtk-doc-1.12 -type d ! -perm -200 -exec chmod u+w {} ';' && rm -fr gtk-doc-1.12; }; } test -d gtk-doc-1.12 || mkdir gtk-doc-1.12 cp: cannot create regular file `gtk-doc-1.12/m4/gnome-doc-utils.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/ltsugar.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/ltversion.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/libtool.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/ltoptions.m4': Permission denied cp: cannot create regular file `gtk-doc-1.12/m4/lt~obsolete.m4': Permission denied make[1]: *** [distdir] Error 1 make[1]: Leaving directory `/home/ensonic/projects/gnome/gtk-doc/gtk-doc/gtk-doc-1.12/_build' make: *** [distcheck] Error 2 l gtk-doc-1.12/m4/ insgesamt 312 dr-xr-xr-x 2 ensonic users 4096 25. Nov 23:05 ./ dr-xr-xr-x 11 ensonic users 4096 25. Nov 23:20 ../ -r--r--r-- 1 ensonic users 1705 25. Nov 23:05 gnome-doc-utils.m4 -r--r--r-- 1 ensonic users 605 1. Okt 00:16 gtkdoc_jh_check_xml_catalog.m4 -r--r--r-- 1 ensonic users 972 1. Okt 00:16 gtkdoc_jh_path_xml_catalog.m4 -r--r--r-- 1 ensonic users 259710 25. Nov 23:05 libtool.m4 -r--r--r-- 1 ensonic users 11938 25. Nov 23:05 ltoptions.m4 -r--r--r-- 1 ensonic users 4372 25. Nov 23:05 ltsugar.m4 -r--r--r-- 1 ensonic users 701 25. Nov 23:05 ltversion.m4 -r--r--r-- 1 ensonic users 5707 25. Nov 23:05 lt~obsolete.m4 l m4/ insgesamt 312 drwxr-xr-x 2 ensonic users 4096 25. Nov 23:05 ./ drwxr-xr-x 12 ensonic users 4096 25. Nov 23:20 ../ -rw-r--r-- 1 ensonic users 1705 25. Nov 23:05 gnome-doc-utils.m4 -rw-r--r-- 1 ensonic users 605 1. Okt 00:16 gtkdoc_jh_check_xml_catalog.m4 -rw-r--r-- 1 ensonic users 972 1. Okt 00:16 gtkdoc_jh_path_xml_catalog.m4 -rw-r--r-- 1 ensonic users 259710 25. Nov 23:05 libtool.m4 -rw-r--r-- 1 ensonic users 11938 25. Nov 23:05 ltoptions.m4 -rw-r--r-- 1 ensonic users 4372 25. Nov 23:05 ltsugar.m4 -rw-r--r-- 1 ensonic users 701 25. Nov 23:05 ltversion.m4 -rw-r--r-- 1 ensonic users 5707 25. Nov 23:05 lt~obsolete.m4
Problem solved - its was because I had "m4" in EXTRA_DIST. Sorry for the troubles.