After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591316 - Bad parameters for notify::<property> callbacks
Bad parameters for notify::<property> callbacks
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-10 11:36 UTC by Owen Taylor
Modified: 2009-08-10 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Owen Taylor 2009-08-10 11:36:37 UTC
In three instances we have:

appDisplay.js:            this._name.connect('notify::allocation', Lang.bind(this, function (n, alloc) {
appDisplay.js-                let x = this._name.x;
appDisplay.js-                let y = this._name.y;
appDisplay.js-                let width = this._name.width;
appDisplay.js-                let height = this._name.height;
--
genericDisplay.js:        this._list.connect('notify::n-pages', Lang.bind(this, function (grid, alloc) {
genericDisplay.js-            this._updateDisplayControl(true);
genericDisplay.js-        }));
genericDisplay.js:        this._list.connect('notify::page', Lang.bind(this, function (grid, alloc) {
genericDisplay.js-            this._updateDisplayControl(false);
genericDisplay.js-        }));

The second parameter of a notify:: signal is actually a 'param spec' - an object with information about the property.It's not the allocation for notify::allocation. It's definitely not the allocation for notify::n-pages. In all cases above we can just ignore both parameters and use 'function() {...}' as we do elsewhere in the code.