GNOME Bugzilla – Bug 590946
LastStreamError access
Last modified: 2009-11-10 10:17:43 UTC
It would be nice to have access to the LastStreamError field in the CoreTracks table when creating smart play lists. Given this, I could create a smart playlist that showed me all of the database entries that are failing to find a file to play.
Created attachment 140251 [details] [review] Added PlaybackError query field
Created attachment 140252 [details] [review] Fixed a typo.
I was so pumped to patch my 1.5.0 release of Banshee and report how wonderful this patch was but unfortunately, it seems that there has been quite a bit of change between HEAD (presumably where this patch applies) and 1.5.0. :-( Will there be a new pre-1.6.0 release coming from HEAD any time soon?
(In reply to comment #3) > Will there be a new pre-1.6.0 release coming from HEAD any time soon? There should be 1.5.1 (aka 1.6 beta 2) out in the coming weeks though I'm not sure about exact date. You can always try the git master, just back up your database before you do.
This is interesting; I'm fine with it. It also lays the ground work for a TrackMediaAttributes query field w/ the enum stuff. I guess we're mostly string frozen for now so committing this will have to wait for after 1.6. I'd suggest using the AliasedObjectSet class so that each enum value can have multiple aliases (translated and not), just like the fields themselves can. Eg you'd be able to do error:missing error:notfound error:ResourceNotFound and they'd all do the same thing. One mistake I've meant for a while to correct w/ the QueryField stuff is for them I have one Catalog.GetString per English alias, but allow blank translations in case there isn't a good one for a given English alias. But there can't ever be more localized aliases than there are English ones. So the fix would be to accept just one comma (or something)-separated translated value.
Created attachment 141053 [details] [review] Use AliasedObjectSet for the EnumQueryValue.Items (In reply to comment #5) > This is interesting; I'm fine with it. It also lays the ground work for a > TrackMediaAttributes query field w/ the enum stuff. I guess we're mostly > string frozen for now so committing this will have to wait for after 1.6. I created bug 592197 so that the idea is not forgotten. I will work on it after 1.6 > I'd suggest using the AliasedObjectSet class so that each enum value can have > multiple aliases (translated and not), just like the fields themselves can. Eg > you'd be able to do > > error:missing > error:notfound > error:ResourceNotFound > > and they'd all do the same thing. Done. > One mistake I've meant for a while to > correct w/ the QueryField stuff is for them I have one Catalog.GetString per > English alias, but allow blank translations in case there isn't a good one for > a given English alias. But there can't ever be more localized aliases than > there are English ones. So the fix would be to accept just one comma (or > something)-separated translated value. I created a separate bug 592198 with a patch as it doesn't break the string freeze.
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Did this patch make it into 1.6 beta2 (1.5.1)? I don't see why it shouldn't have given this patch was available far prior to 1.5.1 being cut. I still don't see anything about error counts in the smart playlist creator.
No, it didn't. Alexander, please commit when you get a chance. Thanks for the patch!
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.