Bug 590702 - Rygel should provide thumbnails for items
Rygel should provide thumbnails for items
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Zeeshan Ali (Khattak)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-08-04 06:06 UTC by James Henstridge
Modified: 2009-09-08 16:31 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Add-a-basic-PNG-thumbnail-transcoder.patch (11.40 KB, patch)
2009-08-04 06:14 UTC, James Henstridge
none Details | Diff | Review
0001-Add-a-basic-PNG-thumbnail-transcoder.patch (11.65 KB, patch)
2009-08-26 06:17 UTC, James Henstridge
rejected Details | Diff | Review

Description James Henstridge 2009-08-04 06:06:23 UTC
Rygel should be able to publish thumbnails for media items.
Comment 1 James Henstridge 2009-08-04 06:14:44 UTC
Created attachment 139840 [details] [review]
0001-Add-a-basic-PNG-thumbnail-transcoder.patch

Here is a basic implementation that plugs in using the transcoder interface, building on top of the request handling changes from bug 590643.

It does not generate any thumbnails, but will publish pre-generated thumbnails (e.g. the ones Nautilus generates when browsing a folder).  I've tested this with a PS3, and it seems to work pretty well.
Comment 2 James Henstridge 2009-08-26 06:17:39 UTC
Created attachment 141722 [details] [review]
0001-Add-a-basic-PNG-thumbnail-transcoder.patch

Updated version of patch to work with newer Rygel code (still depends on patches from bug #590643).
Comment 3 Zeeshan Ali (Khattak) 2009-09-04 11:16:53 UTC
Comment on attachment 141722 [details] [review]
0001-Add-a-basic-PNG-thumbnail-transcoder.patch

DLNA docs explicitly requires the thumbnails to be in JPEG format. The docs say that MediaServer can provide thumbnails in additional formats like PNG but the primary format is JPEG.

Hence I have to reject this patch and will try to implement something similar on top of hildon-thumbnailer (http://gitorious.org/maemo-af/hildon-thumbnail) that not only satisfy the DLNA thumbnail format requirements but also builds readily on normal gnome desktop (don't let the name mislead you) and is readily available on N900.
Comment 4 Zeeshan Ali (Khattak) 2009-09-08 16:31:47 UTC
Just pushed a bunch of changes to git master that adds support for thumbnailer. Rygel now provides either the jpeg thumbnails generated by hildon-thumbnailer or the PNG ones from the fdo standard directory.

Next step would be to ask thumbnailer service (if available) to queue the thumbnail generation of a thumbnail if it doesn't already exist.

Note You need to log in before you can comment on or make changes to this bug.