GNOME Bugzilla – Bug 590648
Text in cover editor does not show up automatically
Last modified: 2010-05-11 14:49:33 UTC
I added two songs to a new audio project and opened the cover editor: no disc title and track information visible. Now, if I click into the cover/back/side fields the text shows up as soon as I put the cursor into the line.
There's no error or warning output on the console btw
This bug is caused by GTK+ client side windows. Running brasero with the environment variable GDK_NATIVE_WINDOWS=1 works around the problem.
See also: https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/469459
Oh, and the bug should be confirmed, btw.
Thanks for the report. I have gtk+ version 2.18.3 and I don't see any problem. No disappearing text whatsoever (and GDK_NATIVE_WINDOWS is not set either).
Despite the fact I can't reproduce it, I managed to think of a fix. It turns out that "map" signal is no longer sent with recent version of gtk. Now BraseroJacketView used gdk_window_show () in the callback for "map". I moved the call to the callback for "realize". Please try it in master or in next version of brasero 2.28 and let me know if it helps. Thanks
(In reply to comment #6) > Despite the fact I can't reproduce it, I managed to think of a fix. It turns > out that "map" signal is no longer sent with recent version of gtk. Now > BraseroJacketView used gdk_window_show () in the callback for "map". I moved > the call to the callback for "realize". > > Please try it in master or in next version of brasero 2.28 and let me know if > it helps. Thanks Hi, Strange that you couldn't reproduce. I've seen similar problems in other programs with this new GTK+-version (disappearing widgets, etc), so that's what made me test brasero with GDK_NATIVE_WINDOWS set. Might be some difference with X server or graphics driver, perhaps.. I'm running Ubuntu Karmic. GTK+ is version 2.18.3 and brasero is at version 2.28.2. I'll try the fix as soon as possible. Your description of the fix makes me think the patch is small. Would it apply easily to current version in Ubuntu (2.28.2) ? If so, could you attach the patch to this bug report ? It would be easier for me just to patch the current version of the Ubuntu source package and test. Regards, Øyvind
The change has not been backported to 2.28 branch but to master. It's the following: db06d49d84c5b4840707fceb135b534b635a1ee6 Fix #602888 - The files on new directory on Brasero project isn't saved correctly. This should be backported to 2.28
Created attachment 149271 [details] [review] The said patch
Hi, I think you mean this one instead: http://git.gnome.org/cgit/brasero/commit/?id=0196d9b166cc0e3e3e43d72c8e635e2487c92a6c [A potential fix for #590648 - Text in cover editor does not show up automatically Show the internal window on realize event not on the map one (which is not emitted with recent versions) This fix should be backported into 2.28] I backported this patch to brasero 2.28.2 that comes with Ubuntu Karmic and rebuilt it. The patch doesn't seem to do any harm, but it also does *not* fix the problem with disappearing text. This bug does not seem to be dependent on low-level differences like graphics driver, since I can reproduce it both on an x86 machine w/open source ATI radeon driver and another x86-64 one with proprietary nvidia driver (both running Ubuntu Karmic). Regards, Øyvind
Perhaps it's related to expose-handling ? See http://library.gnome.org/devel/gtk/2.18/gtk-migrating-ClientSideWindows.html In particular: «[...] One change that can cause problems for some applications is that GDK is more aggressive about optimizing away expose events. Code that does more than just repainting exposed areas in response to expose events may be affected by this. [...]» To be honest, I'm just guessing here, since I am not in any way familiar with the brasero code base.
The problem still exists in Brasero 2.29.91, Ubuntu Lucid beta 1. Since the status is NEEDINFO, I'll quote my comment from Launchpad: "It can also be reproduced when burning a normal data cd/dvd: 1) Open Brasero 2) Choose Data Project 3) Select Tools -> Cover Editor 4) Scroll down to the back, and add some text 5) Scroll up again, so that the text is "hidden" in the editor-window 6) Scroll down again, and see that the text has disappeared The text gets visible again when you click on a text-line, or when you select text. This happens with all the input-fields. The vertical title fields are not affected (probably because these are not input-fields), but the horizontal title field has the same problem as above." Source: https://bugs.launchpad.net/ubuntu/+source/brasero/+bug/469459 Comment #4
Still a problem in brasero 2.30.0-0ubuntu1 (Ubuntu 10.04 release). Cover editor does not work properly with disappearing/reappearing text during editing.
Good news, after a recent installation I stumbled upon this bug and just managed to fix it for 2.30.2 (and master of course). It appeared that something changed between various versions of an underlying library (GTK+?) and it caused the GtkTextView objects not to refresh properly. Anyway, the patch should be backportable to 2.28 for those who want it. commit a4fe9f17d1ea9f440970be9dd2f70fb732fed83c Author: Philippe Rouquier <bonfire-app@wanadoo.fr> Date: Tue May 11 18:48:43 2010 +0200 Fix #590648 - Text in cover editor does not show up automatically