GNOME Bugzilla – Bug 590588
"Disable touchpad while typing" should ignore modifier keys when monitoring keyboard activity
Last modified: 2009-08-03 18:25:19 UTC
Original Ubuntu bug: https://bugs.edge.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/408095 Binary package hint: gnome-settings-daemon The "Disable touchpad while typing" option is useful to avoid accidental touchpad actions while typing. But the current implementation makes it inconvenient to press e.g. "Ctrl" and "Left touchpad button" simultaneously. (This opens a link in a new tab in Firefox, so it is a handy combination when browsing using a computer with less than three touchpad buttons.) It would be much better if the modifier keys where ignored when monitoring keyboard activity. I don't know if everybody else use modifier key combos as often as me, but for me this qualifies as a potential "papercut". At least the bug has the papercut-quality of being trivially fixable; it is just to start "syndaemon" with a "k" option in gnome-settings-daemon-2.27.5/plugins/mouse/gsd-mouse-manager.c: args[0] = "syndaemon"; args[1] = "-i"; args[2] = "0.5"; args[3] = "-k"; args[4] = NULL; I will attach the patch against GIT as soon as I clone it.
Created attachment 139772 [details] [review] patch against GIT
Sounds reasonable. The patch is broken, though. (C doesn't do dynamic arrays...)
Heh. My very first submission to g-s-d, with a *basic* error... <shame/>. Ah well. I always thought dynamic arrays were a good idea for C ;-) Will attach a new patch in a few (and *then* I wonder about *which* bytes were those I have clubbed to death). Marking current patch as obsolete. Would you rather have git patch or normal diff?
Doesn't really matter. If you cannot commit yourself, I'm likely to rewrite the commit message anyway. ;-)
Created attachment 139803 [details] [review] corrected patch, now expanding argv[*]. Please feel free to adjust the ChangeLog and git log entries. Sorry for the mistake.
Thanks! commit 6162fe172bba49726f640557e2bd27feb742f887 Author: C de-Avillez <...> Date: Mon Aug 3 12:33:40 2009 -0500 add '-k' option to syndaemon call for 'Disable touchpad while typing' Call syndaemon with the '-k' parameter when disabling the touchpad while typing so that modifier keys can still be used, e.g. for Ctrl-Click (bug #590588).
Created attachment 139808 [details] [review] corrected patch. I believe. At least it does compile, now. Jens, this is *really* not my day. I guess having a bout of insomnia did not help. Somehow, my keyboard ate the closing '"' on the -k line. And -- shame on me again -- I did not notice the make error on it. So, instead of + args[3] = "-k; It should be + args[3] = "-k"; That really sucked. I am sorry.
Gah! Serves me right for not building before pushing... Fixed now.