After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590586 - Use msgctxt in translation strings
Use msgctxt in translation strings
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: core application
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Naba Kumar
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-03 08:34 UTC by Gil Forcada
Modified: 2009-09-22 19:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change Q_ macro by C_ macro (1.11 KB, patch)
2009-08-03 08:36 UTC, Gil Forcada
none Details | Review
Now remove the obsolete comments (1.45 KB, patch)
2009-08-03 10:47 UTC, Gil Forcada
accepted-commit_now Details | Review

Description Gil Forcada 2009-08-03 08:34:49 UTC
Hi,

We found that there is still some remaining strings in the old format of giving context to translators, that is:

msgid "context|string to translate"
msgstr "translation"

instead of:
msgctxt "context"
msgid "string to translate"
msgstr "translation"

See http://live.gnome.org/GnomeGoals/MsgctxtMigration for the details.

Attaching a simple patch.
Comment 1 Gil Forcada 2009-08-03 08:36:18 UTC
Created attachment 139769 [details] [review]
Change Q_ macro by C_ macro

Patch that uses the new macro C_ to handle context in translatable strings
Comment 2 André Klapper 2009-08-03 09:50:30 UTC
Shouldn't the "Don't include the prefix "recent menu label|" in the translation." comments get removed too?
Comment 3 Gil Forcada 2009-08-03 10:39:29 UTC
ouch  ... I did it just after waking up so I have an excuse ...

Here goes a second version :)

Thanks André,
Comment 4 Gil Forcada 2009-08-03 10:47:05 UTC
Created attachment 139776 [details] [review]
Now remove the obsolete comments
Comment 5 Gabor Kelemen 2009-08-04 08:09:40 UTC
Excuse me, but most of those comments are actually useful, so...

-        /* This is the label format that is used for the first 10 items 
-         * in a recent files menu. The %d is the number of the item,
-         * the %s is the name of the item. Please keep the _ in front
-         * of the number to give these menu items a mnemonic.

this and

-        /* This is the format that is used for items in a recent files menu. 
-         * The %d is the number of the item, the %s is the name of the item. 

is not the part to throw out :). Only this is obsolete:

-         * Don't include the prefix "recent menu label|" in the translation.
Comment 6 Sébastien Granjoux 2009-08-04 20:13:57 UTC
It seems that for using C_ we need  intltool > 0.40.1 and glib > 2.18 while we require currently only intltool > 0.35 and glib > 2.16.

Is it really useful to commit the change now, or can this wait for the next cycle 2.29 ?

Comment 7 Gil Forcada 2009-08-04 21:07:42 UTC
All other modules in the GNOME release set are using those versions since a GnomeGoal was set to use that macro.

But still, if you think that can wait for next version its up to you. Make sure bump version requirements just after releasing so there aren't going to be any surprises later on the cycle.

Comment 8 Johannes Schmid 2009-09-22 13:45:17 UTC
Seb, can you take care of it as we have branched for 2.28 now. Thanks!
Comment 9 Sébastien Granjoux 2009-09-22 19:30:40 UTC
Ok, it is committed. Thanks for your patch and your report.