GNOME Bugzilla – Bug 590586
Use msgctxt in translation strings
Last modified: 2009-09-22 19:30:40 UTC
Hi, We found that there is still some remaining strings in the old format of giving context to translators, that is: msgid "context|string to translate" msgstr "translation" instead of: msgctxt "context" msgid "string to translate" msgstr "translation" See http://live.gnome.org/GnomeGoals/MsgctxtMigration for the details. Attaching a simple patch.
Created attachment 139769 [details] [review] Change Q_ macro by C_ macro Patch that uses the new macro C_ to handle context in translatable strings
Shouldn't the "Don't include the prefix "recent menu label|" in the translation." comments get removed too?
ouch ... I did it just after waking up so I have an excuse ... Here goes a second version :) Thanks André,
Created attachment 139776 [details] [review] Now remove the obsolete comments
Excuse me, but most of those comments are actually useful, so... - /* This is the label format that is used for the first 10 items - * in a recent files menu. The %d is the number of the item, - * the %s is the name of the item. Please keep the _ in front - * of the number to give these menu items a mnemonic. this and - /* This is the format that is used for items in a recent files menu. - * The %d is the number of the item, the %s is the name of the item. is not the part to throw out :). Only this is obsolete: - * Don't include the prefix "recent menu label|" in the translation.
It seems that for using C_ we need intltool > 0.40.1 and glib > 2.18 while we require currently only intltool > 0.35 and glib > 2.16. Is it really useful to commit the change now, or can this wait for the next cycle 2.29 ?
All other modules in the GNOME release set are using those versions since a GnomeGoal was set to use that macro. But still, if you think that can wait for next version its up to you. Make sure bump version requirements just after releasing so there aren't going to be any surprises later on the cycle.
Seb, can you take care of it as we have branched for 2.28 now. Thanks!
Ok, it is committed. Thanks for your patch and your report.