GNOME Bugzilla – Bug 590513
Error messages like »Unable to ... location« may need comments for translators
Last modified: 2012-08-22 13:01:35 UTC
Please describe the problem: The latest po file contains strings like #: ../src/file-manager/fm-directory-view.c:5984 msgid "Unable to unmount location" #: ../src/file-manager/fm-directory-view.c:5999 msgid "Unable to eject location" I find these strings really hard translate since I can't imagine how to unmount or eject a location. Some comments for translators may be helpful here. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Or, modify the strings to something a common citizen can comprehend.
I think the idea was to remove eject in favor of unmount or visa versa. CC'd David to see which way this is supposed to be.
Cosimo changed the unmount/eject entries recently. CCing him.
Created attachment 222016 [details] [review] Use more specific text for unmount/eject error messages
Created attachment 222017 [details] [review] Set parent for all mount/eject error dialogs
Review of attachment 222017 [details] [review]: ::: src/nautilus-view.c @@ +6618,3 @@ + + view = NAUTILUS_VIEW (callback_data); + g_object_unref (view); What reference are you releasing here? Was it leaked before?
Review of attachment 222016 [details] [review]: Looks good to me, but we're now in string change announcement period, so we should send a mail to gnome-i18n@ when pushing this.
Created attachment 222033 [details] [review] Set parent for all mount/eject error dialogs I was following the example from file_unmount_callback but I don't think we need to add the ref to the user data in nautilus_file_mount.
Review of attachment 222033 [details] [review]: Looks good now, thanks.
Attachment 222016 [details] pushed as e864875 - Use more specific text for unmount/eject error messages Attachment 222033 [details] pushed as f789398 - Set parent for all mount/eject error dialogs