GNOME Bugzilla – Bug 590401
GstPulseSrc's pulse probe is not initialized correctly
Last modified: 2009-08-03 11:38:10 UTC
I'm pretty new in gstreamer development, so maybe what I've seen as an error is actually intentional. I've asked on IRC, but could not get an answer.
So anyway, in gst_pulsesrc_init(), when "pulsesrc->probe" is initialized, "pulsesrc->device" is passed to gst_pulseprobe_new() as the server string. This does not make a difference since both should be NULL, but it seemed odd to me.
Created attachment 139644 [details] [review]
Here's a suggested patch
Author: Jonathan Tellier <jonathan.tellier at gmail.com>
Date: Mon Aug 3 13:32:12 2009 +0200
pulsesrc: initialize the probe with the server
When creating a new probe, pass the server instead of the device string.