After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590345 - <gd:deleted> handling in GDataDocumentsEntry
<gd:deleted> handling in GDataDocumentsEntry
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: Google Documents service
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2009-07-31 07:39 UTC by Thibault Saunier
Modified: 2009-08-02 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix this litle issue (4.10 KB, patch)
2009-07-31 07:40 UTC, Thibault Saunier
none Details | Review
Handle the deleted parameter (2.59 KB, patch)
2009-08-01 06:02 UTC, Thibault Saunier
committed Details | Review
It doesn't work I guessed. (1.01 KB, patch)
2009-08-01 21:59 UTC, Thibault Saunier
committed Details | Review

Description Thibault Saunier 2009-07-31 07:39:59 UTC
Misse quotaBytesUsed and deleted properties in GDataDocumentsEntry.
Comment 1 Thibault Saunier 2009-07-31 07:40:29 UTC
Created attachment 139608 [details] [review]
Fix this litle issue
Comment 2 Philip Withnall 2009-07-31 14:42:45 UTC
Can you split it out into two separate patches and attach them to bug #588714 please? Also, can you reply there about whether you ever get values for quotaBytesUsed which aren't 0. I only ever get 0, which leads me to question the usefulness of adding API for quotaBytesUsed.

Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 588714 ***
Comment 3 Thibault Saunier 2009-07-31 15:52:54 UTC
hey,
Sorry, I forgot that I already had reported this bug...

I think I always get a 0 for this property, but it's probably goin to b e used later, I think they are implementing it and it will be usefull in the comin days right?


And it irritate me not to be able to see well my important results in GVFS because of the warnings ;)

I split the patch right now! 
Comment 4 Thibault Saunier 2009-08-01 06:02:40 UTC
Created attachment 139669 [details] [review]
Handle the deleted parameter
Comment 5 Thibault Saunier 2009-08-01 06:03:55 UTC
I put the patch for the Delete property handling here. If you think it' s better create a new bug for that, I can do it ;)
Comment 6 Philip Withnall 2009-08-01 10:26:05 UTC
commit 68bd454a875f8f1a83791fff1d3db59399e138c9
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Aug 1 11:23:45 2009 +0100

    Bug 590345 – <gd:deleted> handling in GDataDocumentsEntry
    
    Patch by Thibault Saunier <saunierthibault@gmail.com> to add handling
    for <gd:deleted> tags in the Documents service. Closes: bgo#590345

 docs/reference/gdata-sections.txt                |    1 +
 gdata/gdata.symbols                              |    1 +
 gdata/services/documents/gdata-documents-entry.c |   54 ++++++++++++++++++++--
 gdata/services/documents/gdata-documents-entry.h |    2 +
 4 files changed, 54 insertions(+), 4 deletions(-)
Comment 7 Thibault Saunier 2009-08-01 21:59:56 UTC
Created attachment 139703 [details] [review]
It doesn't work I guessed.
Comment 8 Philip Withnall 2009-08-02 18:40:45 UTC
Perhaps more thorough testing is in order in future?

commit abaa3f0c0eca903206bb81fa28edf4c9213ffb1f
Author: Thibault Saunier <saunierthibault@gmail.com>
Date:   Sun Aug 2 19:39:06 2009 +0100

    [documents] Fix GDataDocumentsEntry:is-deleted
    
    Brown paper bag commit of a fix to the is-deleted property of
    GDataDocumentsEntry, which apparently doesn't have any attributes.
    Closes: bgo#590345

 gdata/services/documents/gdata-documents-entry.c |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)