After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590267 - Thunderbird's rendering of smileys as named paragraphs without accessible text causes Orca to speak the tutorial message inappropriately
Thunderbird's rendering of smileys as named paragraphs without accessible tex...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.27.x
Other All
: Normal normal
: 2.28.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404409
 
 
Reported: 2009-07-30 13:43 UTC by Hammer Attila
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
proposed fix (1.42 KB, patch)
2009-08-01 04:09 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Hammer Attila 2009-07-30 13:43:41 UTC
Please describe the problem:
Dear Developers!

I see an interesting, but disturb problem only with Thunderbird.
When I read any e-mail with Thunderbird 3.0, if the caret positioning a line with contains any simbols (smileys, etc) and Orca says the simbol character, Orca always says the edit box control tutorial message after the simbol character.
For example, I read an e-mail with contains this line:
"The Terminal is the best. ;-)"
Orca says following this line when I navigate this line with arrow keys or sayall the letter:
"The Terminal is the best. ;-) Type in text."
My Orca preference the tutorial checkbox is checked, but old 2.26 stable release does'nt produced this problem.

Attila

Steps to reproduce:
1. Write your e-mail address a letter, with contains text and simbols (:-), :-( etc) characters.
2. Open your wroted e-mail in Thunderbird.
3. Hear the line with contains the simbol characters.


Actual results:
Now Orca always spoken the edit box tutorial message.

Expected results:
Please do not spoken Orca the edit box tutorial message if the edit box line contains simbol characters.

Does this happen every time?
Yes my machine.

Other information:
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-07-31 15:55:57 UTC
That's strange. I'll investigate this one.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-08-01 03:33:57 UTC
Confirmed. Lemme see what I can do.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-08-01 04:01:08 UTC
Patch coming up. Updating the summary to reflect the nature of the problem.
Comment 4 Joanmarie Diggs (IRC: joanie) 2009-08-01 04:09:16 UTC
Created attachment 139665 [details] [review]
proposed fix

This solves the problem for me, and the fix seems safe. Unfortunately the fix happens to be in one of the most frequently needed methods in all of Gecko (getUtterancesFromContents). Therefore, to be absolutely sure that this is a sound solution, I have 3 hours of regression tests to run. :-) Stay tuned!
Comment 5 Hammer Attila 2009-08-01 05:52:07 UTC
Joanmarie, I tested your patch and your patch fantastic.
I do my reproduce test with following simbols: :-), :-):-), :-( and :-(:-(.
Your patch fixed my problem, thank you your quick and good work.

Attila
Comment 6 Joanmarie Diggs (IRC: joanie) 2009-08-01 07:20:55 UTC
Thanks Attila!

The regression tests all passed. Therefore I've committed the patch to master. Closing as FIXED.