After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590265 - [adder] Buffers not clipped on input
[adder] Buffers not clipped on input
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-30 13:28 UTC by Edward Hervey
Modified: 2009-12-24 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Edward Hervey 2009-07-30 13:28:02 UTC 
The incoming buffers are not clipped according to their respective segments.

This will most likely require adding a new callback in gstcollectpads so that 'users' of collectpads can be given the GstCollectData whenever a new buffer comes in and, if needed, clip/drop the buffer before collectpads uses it.

I've tried fixing that in adder alone (without touching gstcollectpads) but it's just not possible (without having a megaton of hack).
Comment 1 Wim Taymans 2009-12-24 15:37:09 UTC 
commit 59ace1b9ee9015f0035e32366296b6c6dd199155
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu Dec 24 16:30:23 2009 +0100

    adder: use collectpads clipping function
    
    Install a clipping function in the collectpads and use the audio clipping helper
    function to perform clipping to the segment boundaries.
    
    Fixes #590265