Not critical - gnome-pilot is not official part of GNOME.

First of all you should definitely get rid of the mega-include "gnome.h" to be able to actually see how much "real" work is needed here.

$:andre\> grep -r "include <gnome" .
./utils/gpilotdcm-client.c:#include <gnome.h>
./utils/gpilotd-client.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-backup.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-backup.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-sync-abs.h:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-standard.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-standard.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-standard-abs.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-standard-abs.h:#include <gnome.h>
./gpilotd/queue_io.c:#include <gnome.h>
./gpilotd/gpilot-gui.c:#include <gnome.h>
./gpilotd/gpilotd-conduit-mgmt.h:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-file.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-file.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-sync-abs.c:#include <gnome.h>
./gpilotd/orbit_daemon_glue.c:#include <gnome.h>
./gpilotd/gpilotd-session-wrapper.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit.gob:#include <gnome.h>
./gpilotd/gnome-pilot-conduit.gob:#include <gnome.h>
./applet/pilot.c:#include <gnome.h>
./drafts/idl/test_client.c:#include <gnome.h>
./drafts/idl/main.c:#include <gnome.h>
./drafts/idl/orbit-daemon-glue.c:#include <gnome.h>
./gpilot-fileman/multifile.c:#include <gnome.h>
./gpilot-fileman/gpilot-fileman.h:#include <gnome.h>
./gpilot-fileman/fileman.c:#include <gnome.h>
./gpilot-fileman/preferences.c:#include <gnome.h>
./capplet/gnome-pilot-cdialog.h:#include <gnome.h>
./capplet/gnome-pilot-ddialog.h:#include <gnome.h>
./capplet/gnome-pilot-pdialog.h:#include <gnome.h>
./capplet/pilot.c:#include <gnome.h>
./capplet/gnome-pilot-capplet.h:#include <gnome.h>
./capplet/gnome-pilot-druid.h:#include <gnome.h>
./capplet/gpilotd-control-applet.c:#include <gnome.h>
./capplet/util.h:#include <gnome.h>
./conduits/backup/backup_conduit.c:#include <gnome.h>
./conduits/test/test_conduit.c:#include <gnome.h>
./conduits/file/file_conduit.c:#include <gnome.h>
./conduits/file/gpilot_install_file.c:#include <gnome.h>

Created attachment 140995 [details] [review]
Remove "#include <gnome.h>", "#include <libgnome/libgnome.h>" and "#include <libgnomeui/libgnomeui.h>"

This should be VERY carefully reviewed.
I basically commented ALL these includes and added back stuff when needed.
It *could* be that some files are not compiled by default and that I removed too much as I just ran autogen.sh, make and make install and don't know about any specific flags I could set.

There's only one flag I was unable to remove as the error really confused me:
/conduits/file/file_conduit.c:#include <libgnome/libgnome.h>

Thanks, André.  I'll review as early as possible.  It certainly helps focus our attention on what's required and will help us track progres..

There were a couple of clean ups required, to avoid inclusion of gi18n.h and gi18n-lib.h simultaneously, and a couple of other small things.  After fixing a bunch of old signedness issues I can now compile gnome-pilot with -Werror again.

The problem with file_conduit.c was that pi-file.h seems to use "FILE" without an include file to define it.  That was creeping in via libgnome.h

I should be ready to commit this later today.

Yeah, I admit that my patch was very rough - just wanted to have something initial that work can be continued on.

With regard to Glib/Gtk #includes also be aware that soon only toplevel includes should be used: http://live.gnome.org/GnomeGoals/CleanupGTKIncludes http://live.gnome.org/GnomeGoals/CleanupGlibIncludes (though I personally currently expect GTK3 to happen later than GNOME3).

(In reply to comment #5)
> I should be ready to commit this later today.

A friendly *ping*. ;-)

Matt and myself committed several changes these days. Now the git-master is 
$grep -r "include <gnome" .
./gpilotd/gnome-pilot-conduit.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit.h:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-file.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-file.h:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-backup.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-backup.h:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-standard.c:#include <gnome.h>
./gpilotd/gnome-pilot-conduit-standard.h:#include <gnome.h>

After GnomeDruid -> GtkAssistant is done, I think it is safe to close this bug.

This work is mostly done now.  libgnome* is still in use for gnome_program_init; this is still handy to get the corba stuff initialised until we manage to rip out bonobo.  work work work ! :)

Comment on attachment 140995 [details] [review]
Remove "#include <gnome.h>", "#include <libgnome/libgnome.h>" and "#include <libgnomeui/libgnomeui.h>"

Committed with changes.

Cool. Remaining:

./utils/gpilotdcm-client.c:#include <libgnomeui/gnome-ui-init.h>
./utils/gpilotd-client.c:#include <libgnomeui/gnome-ui-init.h>
./gpilotd/gpilotd.c:#include <libgnome/gnome-init.h>
./gpilotd/gpilotd.c:#include <libgnomeui/gnome-ui-init.h>
./conduits/file/gpilot_install_file.c:#include <libgnomeui/gnome-ui-init.h>

Hi Andre,

Thanks for your help in this stuff.

I think I can remove the includes above simply by replacing LIBGNOMEUI_MODULE with LIBGNOME_MODULE, but that still leaves us with with libgnome until (at least) bonobo is removed.  It got a bit late last night... :)

libgnomeui is now gone.

Created attachment 150519 [details] [review]
Completely remove libgnome dependency

This patch removes libgnome dependency completely. I've used gtk_init_with_args() to replace gnome_program_init().

ping - can Javier's patch get a review/commit?

Thanks for the patch, Javier.  I should be able to review and commit this weekend.

See comment 9.  We can't get rid of gnome_program_init until we remove the bonobo stuff.  Either that, or we need another way of initialising bonobo.

Review of attachment 150519 [details] [review]:

Needs work.  Can't rip out gnome_program_init() just yet, as it is required for initialising bonobo.

Ok Matt, setting dependency then

Work progressing on dbus branch.  libgnome is gone.  libgnomeui and bonobo remain only via panel-applet dependency.  Not sure when the "bonoboless" panel is going to be available...

(In reply to comment #20)
> Not sure when the "bonoboless" panel is going to be available...

It's available for about two months now.

Thanks, I'll take a look at how to migrate the panel applet while keeping backwards compatibility for pre 2.31.x

I've merged the recent dbus branch back to master, so gnome-pilot/ shouldn't contain any deprecated symbols.

This is now fixed in head.