After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589865 - In the report "Budget flow" period it doesn't work ok
In the report "Budget flow" period it doesn't work ok
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Reports
2.3.x
Other All
: Normal normal
: ---
Assigned To: Andreas Köhler
Andreas Köhler
Depends on:
Blocks:
 
 
Reported: 2009-07-27 12:16 UTC by Hortencio Peregrino
Modified: 2018-06-29 22:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
src/report/standard-reports/budget-flow.scm period - 1 correction (926 bytes, patch)
2011-08-25 02:47 UTC, Mikhail TSaplin
committed Details | Review
patch file to be applied on budget-flow.scm in GnuCash 2.5.0 (1.44 KB, patch)
2013-04-25 19:06 UTC, Carsten Rinke
committed Details | Review

Description Hortencio Peregrino 2009-07-27 12:16:32 UTC
Please describe the problem:
The data in report refer to next period. I can't see the period 1.

Steps to reproduce:
1. Acess the report "Budget Flow"
2. Select option
3. select general
4. keep period as 1
5. select Apply
6. The data in report refer to period 2


Actual results:
The data in report refer to next period. I can't see the period 1.

Expected results:
I would like can see the correct period

Does this happen every time?
Yes

Other information:
I sugest that the label of the field, in portuguese, show up as "Período"
Comment 1 Nick 2011-03-31 17:20:41 UTC
Still present in 2.4.4 (Windows). 

I.e. my budget starts on 1/1/2011 but the period 1 flow report gives the date as 1/2/2011 with associated budget values from 1/2/2011 to 28/2/2011.
Comment 2 Mikhail TSaplin 2011-08-25 02:47:39 UTC
Created attachment 194666 [details] [review]
src/report/standard-reports/budget-flow.scm period - 1 correction
Comment 3 Mikhail TSaplin 2011-08-25 02:48:58 UTC
Comment on attachment 194666 [details] [review]
src/report/standard-reports/budget-flow.scm period - 1 correction

Also present in 2.4.7.
Comment 4 Mikhail TSaplin 2011-08-25 02:50:42 UTC
Comment on attachment 194666 [details] [review]
src/report/standard-reports/budget-flow.scm period - 1 correction

The problem is using period numbers started from 1 in budget values list that starts from zero.
Comment 5 hac 2011-09-27 00:29:26 UTC
Same here, agree with mikhail, a "-1" is needed somewhere in the code.
Comment 6 Carsten Rinke 2013-04-25 19:06:45 UTC
Created attachment 242456 [details] [review]
patch file to be applied on budget-flow.scm in GnuCash 2.5.0

First of all, I can confirm
- that this bug still occurs in GnuCash 2.5.0 (tested with Ubuntu 12.04)
- the patch uploaded by Mikhail TSaplin is still applicable and does the trick

I also noticed that when now e.g. period 1 is selected, the headline of the report still shows the date as defined with period 2.

Therefore I upload this 2nd patch that fixes this headline issue by introducing the (- period 1) also at this point.

So in order to fix it completely, both patches need to be applied.

This bug should at least be set to status NEW.
Comment 7 Geert Janssens 2013-05-02 15:52:31 UTC
Thank you both for your patches.

The reason Mikhail's patch got unnoticed for so long is because it wasn't marked as a patch. That means that the usual bugzilla search queries for patches didn't pick it up.

I have now changed this (and will apply the patch shortly).
Comment 8 Geert Janssens 2013-05-02 15:52:59 UTC
Comment on attachment 194666 [details] [review]
src/report/standard-reports/budget-flow.scm period - 1 correction

Looks ok to me. I'll apply it shortly.
Comment 9 Geert Janssens 2013-05-02 15:53:59 UTC
Comment on attachment 242456 [details] [review]
patch file to be applied on budget-flow.scm in GnuCash 2.5.0

@Carsten: why do you change the name of the report in your patch ? Is this an oversight or intentional ?
Comment 10 Geert Janssens 2013-05-10 19:19:29 UTC
Comment on attachment 194666 [details] [review]
src/report/standard-reports/budget-flow.scm period - 1 correction

Committed for the 2.5 series in r22966, and for the 2.4 series in r22973.

Thank you very much !
Comment 11 Geert Janssens 2013-05-10 19:20:13 UTC
Comment on attachment 242456 [details] [review]
patch file to be applied on budget-flow.scm in GnuCash 2.5.0

I have reverted the unwanted name change and committed for the 2.5 series in r22967, and for the 2.4 series in r22974.

Thank you very much !
Comment 12 John Ralls 2018-06-29 22:25:29 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=589865. Please update any external references or bookmarks.