After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589769 - Remove deprecated Glib and GTK+ symbols
Remove deprecated Glib and GTK+ symbols
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: 0.1.2
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks: 560423 585692
 
 
Reported: 2009-07-26 14:50 UTC by André Klapper
Modified: 2009-10-08 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove deprecated GTK+ symbols (1.33 KB, patch)
2009-08-19 02:45 UTC, Javier Jardón (IRC: jjardon)
none Details | Review

Description André Klapper 2009-07-26 14:50:08 UTC
According to http://www.gnome.org/~fpeters/299.html gegl uses deprecated Glib and GTK symbols. These symbols will be removed for GTK 3.

* g_win32_get_package_installation_subdirectory
* GtkSignalFunc
* gtk_signal_connect


$:andre\> grep -r gtk_signal_connect .
./examples/gegl-paint.c:  gtk_signal_connect (GTK_OBJECT (view), "motion-notify-event",
./examples/gegl-paint.c:  gtk_signal_connect (GTK_OBJECT (view), "button-press-event",
./examples/gegl-paint.c:  gtk_signal_connect (GTK_OBJECT (view), "button-release-event",

$:andre\> grep -r GtkSignalFunc .
./examples/gegl-paint.c:      (GtkSignalFunc) paint_motion, NULL);
./examples/gegl-paint.c:      (GtkSignalFunc) paint_press, NULL);
./examples/gegl-paint.c:      (GtkSignalFunc) paint_release, NULL);

$:andre\> grep -r g_win32_get_package_installation_subdirectory .
./gegl/gegl-init.c:     g_win32_get_package_installation_subdirectory (NULL,
Comment 1 Martin Nordholts 2009-07-26 18:59:08 UTC
Let's look at this for the next release.

A patch (or rather, git commit) that fixes it would be appreciated.
Comment 2 André Klapper 2009-07-27 14:45:08 UTC
Sorry, I myself don't code - I've set the gnome-love keyword here.

For API refs see http://library.gnome.org/devel/gtk/unstable/gtk-Signals.html#gtk-signal-connect and http://library.gnome.org/devel/glib/stable/glib-Windows-Compatibility-Functions.html#g-win32-get-package-installation-subdirectory . And I assume it's just a simple "GtkSignalFunc" -> "GCallback"...
Comment 3 Michael Schumacher 2009-08-13 20:44:33 UTC
g_win32_get_package_installation_subdirectory is gone.
Comment 4 Javier Jardón (IRC: jjardon) 2009-08-19 02:45:03 UTC
Created attachment 141130 [details] [review]
Remove deprecated GTK+ symbols

This patch removes the remaining GTK+ symbols
Comment 5 Javier Jardón (IRC: jjardon) 2009-10-08 11:35:59 UTC
Hello,

Could some GEGL developer review the latest patch (and we can close this bug ;))?
Comment 6 Martin Nordholts 2009-10-08 19:15:35 UTC
Thanks for the patch, looks fine to me, pushed

commit ccb3a25eb984191ba0236f3a15902c8bcd1a82f0
Author: Javier Jardón <javierjc1982@gmail.com>
Date:   Wed Aug 19 04:43:34 2009 +0200

    Bug 589769 - Remove deprecated Glib and GTK+ symbols

 examples/gegl-paint.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)