After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589584 - always show icon for rotate/flip menu items
always show icon for rotate/flip menu items
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other Linux
: Normal minor
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-24 09:15 UTC by Frederic Peters
Modified: 2009-07-24 12:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Always show icons of rotate/flip menu items (GNOME bug 589584) (1.66 KB, patch)
2009-07-24 09:40 UTC, Frederic Peters
committed Details | Review

Description Frederic Peters 2009-07-24 09:15:13 UTC
Since bug 557469 the rotate and flip menu items no longer have icons, but as the icon is a strong visual hint on the action they could be seen as exceptions.

21:36 < andreasn> but I think it's one of those cases that falls under " or if it makes the items in that menu segment very much more recognizable."
21:38 < andreasn> as rotate clockwise could need some visualization in order to show what it means

Could gtk_image_menu_item_set_always_show_image() be applied to those items?
Comment 1 Frederic Peters 2009-07-24 09:40:03 UTC
Created attachment 139138 [details] [review]
Always show icons of rotate/flip menu items (GNOME bug 589584)
Comment 2 Felix Riemann 2009-07-24 12:40:48 UTC
Thanks. Committed as commit 76ebcbeac7bf4bead09588fc0f17bfdb54b53b75 .

I've also raised the gtk+ dependency as gtk_image_menu_item_set_always_show_image requires gtk+-2.15.2.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.