GNOME Bugzilla – Bug 589409
the Event struct in EmpathyEventManager should contain an enum with the event type
Last modified: 2010-09-20 14:14:36 UTC
To enable some functionality wrt. notifications it would be nice if the Event structure in the notification had a enum value to describe their type (incoming text channel, subscription, etc)
Good idea, that would allow a cleaner implementation of #580794
In order to fix Bug 580794, I've implemented such an enum type. It might be a good idea that someone makes sure that all useful types are present though.
Created attachment 144597 [details] [review] Code based on Jonathan's branch but, unfortunatelly, as the patches were badly recorded, I had to re-record it src/empathy-event-manager.c | 52 +++++++++++++++++++++++++----------------- src/empathy-event-manager.h | 20 ++++++++++++---- 2 files changed, 46 insertions(+), 26 deletions(-)
This bug has been fixed in master. Patch will probably be backported to 2.28. commit 34010895cf8b0915b5f6bb162ba6165271b48c3c Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Fri Oct 2 15:16:27 2009 +0100 add event type to EmpathyEvent (#589409)