GNOME Bugzilla – Bug 589345
Fedora patch for using beagle/tracker at runtime instead of compiletime
Last modified: 2010-03-08 11:07:38 UTC
This patch is being applied in fedora since a lot of time and, also, its spec says: # Why is this not upstream ? Patch6: nautilus-2.23.5-dynamic-search.patch I have tried to search in gnome bugzilla and I have failed to find any bug related with it Thanks for checking it
Created attachment 138977 [details] [review] nautilus-2.23.5-dynamic-search.patch
Comment on attachment 138977 [details] [review] nautilus-2.23.5-dynamic-search.patch May need to check that this still works with Jurg's Tracker 0.7 patch, but otherwise I don't see any reason not to accept this.
Created attachment 145952 [details] [review] nautilus-2.28.1-dynamic-search.patch Updated patch with tracker 0.7 support, incl. more code cleanup. I've removed compile time dependencies completely, libraries load in order: beagle first, tracker as a second if beagle not available, falling back to classic search if neither is available.
Tested with beagle-0.3.9, tracker-0.6.95 and tracker-0.7.3
Review of attachment 145952 [details] [review]: The patch itself looks good to me. Honestly, in the long run, I don't think it's worth to support more than one indexing engine though, and if I had to choose, I'd choose tracker, as it's now an approved external dependency, is well-maintained and has a lot of new and interesting features; this can be a nice solution in the meanwhile anyway. Could you please update the patch moving tracker to be the first option among the engines? Also, before we commit this, you should assure that your patch takes into account bug #608976. Probably those functions can be easily replaced with something else.
Created attachment 155333 [details] [review] nautilus-2.28.1-dynamic-search.patch Updated patch with new tracker API support, tested with 0.6.96 and 0.7.23. Everything is done dynamically, creating nice mess in the source file. Also, tracker is now preferred search engine.
Tomas, thanks for the follow-up. Why did you mark the new patch as 'needs-work'?
Committed to master per discussion on irc. commit e1e1fe0d505bdb9b53d7204bba0abeee52f73bca Author: Tomas Bzatek <tbzatek@redhat.com> Date: Mon Mar 8 12:01:49 2010 +0100 Load tracker/beagle at runtime Dynamically load tracker (preferred) and beagle client libraries on demand if available. This allows more flexibility for packagers and users. See bug 589345 for details.