GNOME Bugzilla – Bug 589278
Support AM_SILENT_RULES
Last modified: 2012-02-20 16:38:13 UTC
With automake 1.11, AM_SILENT_RULES (or the silent-rules option) allows to make builds a bit nicer. See http://www.gnu.org/software/hello/manual/automake/Options.html for more details. However, currently, gnome-doc-utils rules that get integrated in the Makefile don't support this and the build of other modules is therefore still a bit verbose.
Note that you can use $(AM_V_GEN) to make custom commands silent See http://live.gnome.org/GnomeGoals/NicerBuilds for more info
*** Bug 592001 has been marked as a duplicate of this bug. ***
I probably won't be able to spend any time on this in the near future, but I'll try to review any patches that might appear. Note that gnome-doc-utils.make does stuff like this: @if foo; then \ echo "frobnicate foo"; \ frobnicate foo; \ fi; From my understanding of how AM_V_GEN and AM_V_at work, they're not going to handle this case very well.
GDU_FROBNICATE_V = $(GDU_FROBNICATE_$(V)) GDU_FROBNICATE_ = $(GDU_FROBNICATE_$(AM_DEFAULT_VERBOSITY)) GDU_FROBNICATE_0 = echo "frobnicate $@"; $(AM_V_at)if foo; then \ $(GDU_FROBNICATE_V) frobnicate foo; \ fi;
Created attachment 151511 [details] [review] Partial patch This is just a partial patch to scratch an itch when compiling gnome-games. I thought I would share it anyway. Fixing this completely probably requires someone who understands g-d-u better than me - or at least some advice about how much should be fixed and how to test it properly. The patch is based on the comment by Behdad.
+ $(AM_V_at)@if ! test -d $(dir $@); then \ "@if" should become "if". The "@" part resides in "$(AM_V_at)" now.
Created attachment 151701 [details] [review] Add partial support for AM_SILENT_RULES Updated patch. Thanks Behdad.
What would be needed before something can be committed? Even the partial patch makes building gnome so much nicer.
ping
Any chance of this getting a review? Without it other modules don't get the full benefit of silent-rules.
Comment on attachment 151701 [details] [review] Add partial support for AM_SILENT_RULES per discussion with shaunm on IRC
It appears that the patch has bitrotted. At least I can no longer get it to build.
Created attachment 204188 [details] [review] 0001-Add-support-for-silent-rules-to-gnome-doc-utils.make.patch New patch, applies cleanly on master.
Created attachment 204194 [details] [review] 0001-Add-support-for-silent-rules-to-gnome-doc-utils.make.patch New patch, now without errors in bootstrapping.
Created attachment 204201 [details] [review] 0001-Add-support-for-silent-rules-to-gnome-doc-utils.make.patch Hmm, I could do better with my last patch... sorry for all the noise. This new patch is my final thoroughly tested patch, please review. Note, this will only add support for silent rules for building packages that use GNOME_DOC_INIT, not for building gnome-doc-utils itself. For gnome-doc-utils itself, I have also made a patch, but that is dependent on how some upcoming changes to intltool will work out, so that will come later.
Created attachment 204202 [details] [review] 0002-Use-silent-rules-for-building-gnome-doc-utils.patch FYI, this second patch lets gnome-doc-utils itself build less verbosely. It builds upon a proposed but not yet accepted patch to intltool, in https://bugs.launchpad.net/intltool/+bug/402516 and thus might need some future change if the intltool patch is not accepted as is. Just wanted to post this patch here anyway, so other people will not need to redo this.
Created attachment 206808 [details] [review] 0002-Use-silent-rules-for-building-gnome-doc-utils.patch Updated my patch for silent building gnome-doc-utils itself to use the new silent rules functionality in intltool.m4 (if available). (See http://bazaar.launchpad.net/~intltool/intltool/trunk/revision/730)
Created attachment 207521 [details] [review] 0001-Add-support-for-silent-rules-to-gnome-doc-utils.make.patch Updated patch, now passing 'make distcheck'. Please review this.
Created attachment 207522 [details] [review] 0002-Use-silent-rules-for-building-gnome-doc-utils.patch Updated second patch with one more silent rule. Please review this as well.
Created attachment 208045 [details] [review] 0001-Add-support-for-silent-rules-to-gnome-doc-utils.make.patch Updated patch, use DB2OMF/DB2HTM instead of XLTPRC.
Created attachment 208046 [details] [review] 0002-Use-silent-rules-for-building-gnome-doc-utils.patch Updated patch; use AM_V_GEN instead of XLTPRC
Sorry for the delay. Thanks for the updated patches. Pushed to master.