After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589229 - Keyboard shortcuts for zoom do not work as expected.
Keyboard shortcuts for zoom do not work as expected.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2009-07-21 09:52 UTC by Michal
Modified: 2012-02-23 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch allows number pad keys to work as zoom shortcuts (2.38 KB, patch)
2012-02-11 20:26 UTC, mclindle
none Details | Review
git format-patch for number pad zoom functionality (2.59 KB, patch)
2012-02-14 02:02 UTC, Richard Bowers
none Details | Review

Description Michal 2009-07-21 09:52:26 UTC
There are new keyboard shortcuts for zoom in ('2', '3', '4', '5') and for zoom out ('Shift+2', 'Shift+3','Shift+4','Shift+5'). Unfortunately they behave strangely on my keyboard.

1. With NumLock enabled:

When I try zoom in, numeric keys on my num pad do not work. Numeric keys over QWERTY keys work properly.

When I try zoom out (Shift+number), numeric keys on my num pad work like arrows. For example: with Shift and key '2' (where is arrow down '↓') zoom values from drop down menu in the statusbar are chosen. Numeric keys over QWERTY keys do not work at all.

2. With NumLock disabled:

When I try zoom in, numeric keys over QWERTY keys work properly. Numeric keys on my num pad work like arrows (as expected).

When I try zoom out (Shift+number), numeric keys over QWERTY keys do not work. Numeric keys on my num pad do nothing (expected: zooming in).

I hope it is quite clear.
Comment 1 Michael Schumacher 2009-08-10 22:44:17 UTC
I guess this is mostly the same reason as in bug #143579.
Comment 2 Benjamin Johnson 2012-02-08 02:49:38 UTC
I've reproduced this bug, and the behavior that I get is exactly as described above; furthermore, when numLock is enabled, and I press "7,8,9" on the number pad simultaneously, the application zooms in (from 200% to 400% for example). Pressing "4,5,6" simultaneously on the number pad zooms out.

As a side note: Myself and a few others have been exploring app/actions/view-actions.c to try and come up with a fix for this bug.
Comment 3 mclindle 2012-02-11 20:26:45 UTC
Created attachment 207362 [details] [review]
Patch allows number pad keys to work as zoom shortcuts
Comment 4 Richard Bowers 2012-02-14 02:02:29 UTC
Created attachment 207510 [details] [review]
git format-patch for number pad zoom functionality

Im a member of the programming team with comment 1 and comment 2. I attached a git format-patch version of the patch developed.
Comment 5 Richard Bowers 2012-02-14 02:03:37 UTC
comment 2 and comment 3 **
Comment 6 Michael Natterer 2012-02-23 19:20:11 UTC
Thanks, fixed in master:

commit e507f406d7abd083dcc8fceb92b984f475a0f525
Author: Richard Bowers <rdbowers@g.cofc.edu>
Date:   Sun Feb 12 12:28:12 2012 -0500

    Bug 589229 - Keyboard shortcuts for zoom do not work as expected
    
    Add extra actions for KP_1 ... KP_5 because they are separate keys.

 app/actions/view-actions.c |   30 ++++++++++++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)