After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589225 - We should check if the contact supports vnc stream tube for Share my desktop
We should check if the contact supports vnc stream tube for Share my desktop
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.27.x
Other All
: Normal minor
: ---
Assigned To: empathy-maint
: 592796 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-07-21 09:29 UTC by Arnaud Maillet
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/check-vinagre-589225 (2.97 KB, patch)
2010-06-18 14:12 UTC, Guillaume Desmottes 		reviewed Details | Review

Description Arnaud Maillet 2009-07-21 09:29:59 UTC 
Whe should check if the contact supports vnc stream tube to display Share my desktop feature.

Other information:
Comment 1 Guillaume Desmottes 2009-07-21 09:40:15 UTC 
In this case I think the menu item should be displayed but unsensitive if the contact doesn't support this kind of tube.
Comment 2 Guillaume Desmottes 2009-08-24 13:21:00 UTC 
*** Bug 592796 has been marked as a duplicate of this bug. ***
Comment 3 Guillaume Desmottes 2010-06-18 13:51:46 UTC 
This is now possible as recent Vinagre is a proper channel handler and we have ContactCapabilities support.
Comment 4 Guillaume Desmottes 2010-06-18 14:12:16 UTC 
Created attachment 164007 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/check-vinagre-589225

 libempathy-gtk/empathy-contact-menu.c |    3 ++-
 libempathy/empathy-contact.c          |   12 +++++++++---
 libempathy/empathy-contact.h          |    4 ++--
 3 files changed, 13 insertions(+), 6 deletions(-)
Comment 5 Danielle Madeley 2010-06-21 10:56:55 UTC 
Review of attachment 164007 [details] [review]:

Looks fine.
Comment 6 Guillaume Desmottes 2010-06-21 12:19:54 UTC 
Merged to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.