GNOME Bugzilla – Bug 588922
Empathy should use ContactInfo
Last modified: 2010-06-15 11:09:37 UTC
Filed from downstream Ubuntu Karmic https://bugs.edge.launchpad.net/ubuntu/+source/empathy/+bug/399761 If you right click on a user name and click info in pidgin you are presented with some useful information about the other user. Real name etc.... However if you do the same in empathy the information is not nearly as informative even though the labelling is the same. Real name = user. For example My real name is Dave Morley, pidgin displays this correctly, it also displays the other channels I'm in. Empathy says Identifier davmor2, alias davmor2. This isn't so useful if someone is after you by name :( nor does it display other channels. This is useful if your in a group i.e. qa to track the channels of importance to the other members and so may be of importance to you also.
This is because Empathy/Gabble doesn't support vCard info atm. This will be fixed once the ContactInfo spec is implemented in Gabble and Empathy.
The telepathy-spec bug regarding ContactInfo: https://bugs.freedesktop.org/show_bug.cgi?id=13350
*** Bug 599083 has been marked as a duplicate of this bug. ***
(In reply to comment #2) > The telepathy-spec bug regarding ContactInfo: > https://bugs.freedesktop.org/show_bug.cgi?id=13350 That's now "RESOLVED FIXED" per comment https://bugs.freedesktop.org/show_bug.cgi?id=13350#c13 "Stable API in 0.19.4."
Empathy branch doing this: http://git.collabora.co.uk/?p=user/xclaesse/empathy.git;a=shortlog;h=refs/heads/contact-info Needs a not yet merged tp-glib branch: http://git.collabora.co.uk/?p=user/xclaesse/telepathy-glib.git;a=shortlog;h=refs/heads/contact-info See telepathy-glib bug: https://bugs.freedesktop.org/show_bug.cgi?id=27676
The needed API is now in telepathy-glib master. I updated Empathy branch.
+} InfoFieldData; +static InfoFieldData info_field_datas[] = Add a \n + w = gtk_label_new (_(field_data->title)); Is that ok from a translation pov? + if (error->domain == G_IO_ERROR && error->code == G_IO_ERROR_CANCELLED) Use g_error_matches() In practice, how long does it take to fetch contact info? Would it be worth to display a spinner to show that we are getting data? Did you review the changes in the glade file? It seems to contain lot of unrelated changes including: - <property name="label" translatable="yes">Information requested…</property> + <property name="label" translatable="yes">Information requested…</property> which is wrong (glade bug iirc).
(In reply to comment #7) > +} InfoFieldData; > +static InfoFieldData info_field_datas[] = > > Add a \n done > > + w = gtk_label_new (_(field_data->title)); > Is that ok from a translation pov? yes > > + if (error->domain == G_IO_ERROR && error->code == G_IO_ERROR_CANCELLED) > Use g_error_matches() done > In practice, how long does it take to fetch contact info? Would it be worth to > display a spinner to show that we are getting data? Depends on the server. With @collabora.co.uk contacts it is instantaneous, with facebook contacts it can takes several minutes, sometimes I'm not even sure it ever get a reply... I already display a label "information requested..." (that part of the glade was still from Gossip!). But a spinner could be nice indeed. > Did you review the changes in the glade file? It seems to contain lot of > unrelated changes including: > - <property name="label" translatable="yes">Information > requested…</property> > + <property name="label" translatable="yes">Information > requested…</property> > which is wrong (glade bug iirc). Didn't see that, removed them. Patch amended.
What's the reason of these changes? Are they ok? - <property name="orientation">vertical</property> + <property name="visible">True</property> Please add a spinner.
done
(In reply to comment #9) > What's the reason of these changes? Are they ok? > - <property name="orientation">vertical</property> Glade does that now... because that property is not needed when using a GtkBox subclass. That's not a problem. > + <property name="visible">True</property> I cleaned a bit widgets that are initially visible/hidden, to make everything visible by default. It's easier to handle in the code.
Looks good. Please merge once Empathy depends on the right tp-glib.
Please add a commit updating the tp-glib dep to 0.11.7 and merge your branch.
merged