GNOME Bugzilla – Bug 588788
GTK+ compilation should work with automake1.10
Last modified: 2009-09-18 10:49:17 UTC
Don't know if this a bug in GTK+ or in automake, but GTK+ should compile with new versions of automake, not only automake1.7
yes, it should. Someone needs to test that it does, and fix issues that come up...
I've compiled gtk+ master today (latest patch http://git.gnome.org/cgit/gtk+/commit/?id=e87db9e44aedeb96d62196a937e5489f004d718c) with automake 1.10 and it works without any problem
Here is a number of things we had to do in glib over time to handle automake version incompatibilities. Some of these probably apply for GTK+: Fri Feb 27 02:00:34 2004 Matthias Clasen <maclas@gmx.de> * acglib.m4: quote AC_DEFUN macro names so automake 1.8 won't whine at us. (#134882) 2006-01-31 Matthias Clasen <mclasen@redhat.com> * autogen.sh: Touch README and INSTALL here to pacify automake. (#329124, Kjartan Maraas, Tim Janik) 2007-11-07 Matthias Clasen <mclasen@redhat.com> * acinclude.m4: * configure.in: Move some inter-*.m4 includes from configure.in to acinclude.m4 to avoid warnings when using automake 1.9. (#449937) 2007-11-09 Matthias Clasen <mclasen@redhat.com> * configure.in: Add AM_PROG_CC_C_O. * Makefile.am: Remove the install-exec-local hook and use configexecincludedir_DATA instead, in an attempt to avoid automake 1.9 <> 1.10 incompatibilities. * glib/Makefile.am: Rename MIRRORING_TAB_SOURCES, since automake 1.10 complains.
I've compiled gtk+ master today (latest patch http://git.gnome.org/cgit/gtk+/commit/?id=ad3be192517c10097b91a618f62fd741d8e681f6 with new version of automake (1.11) and it works without any problem too
Running Gentoo one tends to have lots of build environments around. So I'm not sure precisely what was used to build GTK 2.16.5 here, but automake 1.9.6 and 1.10.2 are installed on our build server presently. So it was one of those. AfC
Anecdotal evidence is not going to keep somebody from going over the things I listed above and verify whether each of them is an issue for GTK+...
(In reply to comment #3) > Fri Feb 27 02:00:34 2004 Matthias Clasen <maclas@gmx.de> > > * acglib.m4: quote AC_DEFUN macro names so automake > 1.8 won't whine at us. (#134882) All the AC_DEFUN are correctly quote: acinclude.m4:AC_DEFUN([GLIB_AC_DIVERT_BEFORE_HELP], acinclude.m4:AC_DEFUN([GTK_ADD_LIB], acinclude.m4:AC_DEFUN([JH_PATH_XML_CATALOG], acinclude.m4:AC_DEFUN([JH_CHECK_XML_CATALOG], m4macros/gtk-2.0.m4:AC_DEFUN([AM_PATH_GTK_2_0], > 2006-01-31 Matthias Clasen <mclasen@redhat.com> > > * autogen.sh: Touch README and INSTALL here to pacify > automake. (#329124, Kjartan Maraas, Tim Janik) Already done in GTK+ code: see autogen.sh file > 2007-11-07 Matthias Clasen <mclasen@redhat.com> > > * acinclude.m4: > * configure.in: Move some inter-*.m4 includes from > configure.in to acinclude.m4 to avoid warnings when > using automake 1.9. (#449937) GTK+ is not using any m4_include macro. > 2007-11-09 Matthias Clasen <mclasen@redhat.com> > > * configure.in: Add AM_PROG_CC_C_O. patch following > > * Makefile.am: Remove the install-exec-local hook and use > configexecincludedir_DATA instead, in an attempt to avoid > automake 1.9 <> 1.10 incompatibilities. install-exec-local is not used in /gtk directory > * glib/Makefile.am: Rename MIRRORING_TAB_SOURCES, since > automake 1.10 complains. MIRRORING_TAB_SOURCES is not used in GTK+ source
Created attachment 140899 [details] [review] Add AM_PROG_CC_C_O Tested with automake1.10 and automake 1.11
Created attachment 140903 [details] [review] Allow compile GTK with automake >= 1.10
Created attachment 140906 [details] [review] Allow compile GTK+ with automake 1.10 and 1.11 Added 1.10 and 1.11 to the warning message
Looks ok, please commit the two patches.
Plase, Could someone commit this? (I don't have commit permissions)