GNOME Bugzilla – Bug 588746
[audiotestsrc] Make sure tags are properly serialized in the dataflow
Last modified: 2009-07-20 11:17:35 UTC
Adder pushes out some tags from the _create() virtual method. The problem is that it has no knowledge of the overall dataflow (i.e. when newsegment has been pushed downstream). The following patch makes audiotestsrc relay it to the base class for proper emission.
Created attachment 138508 [details] [review] audiotestsrc: Make sure tags are properly serialized. We do this by letting the basesrc base class handle the tags.
Any chance to get this one in ? It's causing havoc for pitivi :(
Yes please
commit 196b38d4ef73d937de02f3a020c16afbd81f13c8 Author: Edward Hervey <bilboed@bilboed.com> Date: Sun Jul 12 10:07:34 2009 +0200 audiotestsrc: Make sure tags are properly serialized. Fixes #588746 We do this by letting the basesrc base class handle the tags.
Created attachment 138795 [details] [review] possible new patch unfortunately gst_element_send_event() takes the state lock and can't thus be called from a streaming thread. Instead this patch calls the send_event vmethod directly as a quick fix until there is a nice API in basesrc for this.
Added patch and NULL check. commit 0bb9b75a7535b435779a5776fd2ab5e8bf1e9869 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Mon Jul 20 12:51:30 2009 +0200 audiotestsrc: call send_event directly We can't call gst_element_send_event() from a streaming thread as it gets the state lock. Instead call the send_event method directly until we have a nice API for this in basesrc. Fixes #588746