After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588732 - should not generate .ui files
should not generate .ui files
Status: RESOLVED DUPLICATE of bug 588945
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on: 588945
Blocks:
 
 
Reported: 2009-07-16 02:53 UTC by Matthias Clasen
Modified: 2012-12-16 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixed .ui file (9.51 KB, text/plain)
2009-07-16 02:54 UTC, Matthias Clasen 		Details

Description Matthias Clasen 2009-07-16 02:53:58 UTC 
gtk-builder-convert is just meant as a one-time convertion tool whose results need to be manually checked, not as a tool that you can rely on at build time to get it right.

Here is one problem in the generated profile-new-dialog.ui: one of the buttons does not obey the button-images setting. I will attach a fixed .ui file, but of course, you first have to stop regenerating the .ui files from their glade predecessors...
Comment 1 Matthias Clasen 2009-07-16 02:54:51 UTC 
Created attachment 138494 [details]
fixed .ui file
Comment 2 Christian Persch 2009-07-17 20:04:20 UTC 
I don't agree on gtk-builder-convert being a one-time tool; I certainly don't see any warnings against that in the docs. Furthermore, at the time g-t was converted to GtkBuilder, and also later the last time I checked this, glade-3 was unable to work correctly with the g-t .ui files (they were corrupted on save). Therefore using .ui format natively was out of the question since to me being able to use a UI editor (glade-2 in this case) is essential.
 
I admit that this autogeneration on build causes problems, e.g. bug 553357.

Is this a bug in the original .glade file, or is gtk-builder-convert misconverting this file?
Comment 3 Matthias Clasen 2009-07-17 21:29:20 UTC 
You are right that the docs are not too clear on this point. The strongest hint we have is this:


  A good way to start a migration from libglade to GtkBuilder is
  to run the <link linkend="gtk-builder-convert">gtk-builder-convert</link>
  utility on your glade file, and inspect the resulting output.
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Anyway, glade-3 handles .ui files very well by now, so the 'no editor' argument is not that convincing anymore.
Comment 4 Ionut Biru 2011-02-18 21:41:16 UTC 
gnome-terminal 2.33.5 compiled with-gtk=3.0 is still checking for gtk-builder-convert

note that gtk 3.0.0 doesn't have that anymore.

commit 77ff6992260b19ff04a0823de45142a37532d058
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Mon Jan 17 09:55:16 2011 -0500

    Drop gtk-builder-convert

    It will still be shipped in gtk 2.24.
Comment 5 Christian Persch 2011-02-18 21:57:44 UTC 
I know that. And that commit msg even gives you the hint where to find the script.
Comment 6 Christian Persch 2012-12-16 21:28:31 UTC 

*** This bug has been marked as a duplicate of bug 588945 ***