After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588483 - [flacenc] write padding metadata block
[flacenc] write padding metadata block
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other All
: Normal enhancement
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-07-13 20:43 UTC by Ted M Lin
Modified: 2009-07-16 18:45 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Ted M Lin 2009-07-13 20:43:21 UTC
It would be useful to (optionally) support adding a padding metadata block. By default, 'flac' will add some padding, so future metadata additions/changes won't require file rewrites.


The changes should be pretty minimal:

* add a gstreamer property to handle padding size.

* gst_flac_enc_set_metadata():
  Increase the block array size.
  Allocate another metadata block of type 'FLAC__METADATA_TYPE_PADDING' (as the last metadata block).
  Set 'meta'->length.

* gst_flac_enc_change_state():
  Delete another metadata block.
Comment 1 Sebastian Dröge (slomo) 2009-07-16 18:45:45 UTC
commit 598e0c8cc63ab80a63db68767ca7ff7141c5b307
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Jul 16 20:44:40 2009 +0200

    flacenc: Optionally write a PADDING block
    
    The size of the PADDING block is specified by a new
    "padding" property.
    
    Fixes bug #588483.